feat: updated mime-db to 1.52.0 #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: Added mime-db as dev dep feat: Added script to sync mime-db
Codecov Report
@@ Coverage Diff @@
## main #808 +/- ##
=========================================
Coverage 99.34% 99.35%
=========================================
Files 1921 1921
Lines 177120 179085 +1965
Branches 909 909
=========================================
+ Hits 175967 177932 +1965
Misses 1097 1097
Partials 56 56
|
Shinigami92
requested changes
Apr 8, 2022
Shinigami92
previously approved these changes
Apr 8, 2022
ST-DDT
requested changes
Apr 8, 2022
Co-authored-by: ST-DDT <ST-DDT@gmx.de>
Co-authored-by: ST-DDT <ST-DDT@gmx.de>
Shinigami92
approved these changes
Apr 8, 2022
ST-DDT
approved these changes
Apr 8, 2022
Shinigami92
changed the title
|
Thank you. Great idea. |
|
@prisis just out of the interest: why do we copy it to our source instead of just keeping it as dependency and importing like any other module? |
|
It's the first step, i would like to discuss how we will handle dependencies in the future for faker. For now I just want to provide a way without adding something new :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Added mime-db as dev dep
feat: Added script to sync mime-db
Im proposing a different approach to update the mime-types