Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: extend list of street prefixes for pl locale #844

Merged
merged 2 commits into from
Apr 19, 2022
Merged

feat: extend list of street prefixes for pl locale #844

merged 2 commits into from
Apr 19, 2022

Conversation

pkuczynski
Copy link
Member

No description provided.

@pkuczynski pkuczynski added the c: locale Permutes locale definitions label Apr 18, 2022
@pkuczynski pkuczynski added this to the v6 - Non-Breaking Changes milestone Apr 18, 2022
@pkuczynski pkuczynski self-assigned this Apr 18, 2022
@pkuczynski pkuczynski requested a review from a team as a code owner April 18, 2022 22:24
@codecov
Copy link

codecov bot commented Apr 18, 2022 •
edited
Loading

Codecov Report

Merging #844 (d5f1fdb) into main (f824f9d) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head d5f1fdb differs from pull request most recent head ab7bb19. Consider uploading reports for the commit ab7bb19 to get more accurate results

@@            Coverage Diff             @@
##             main     #844      +/-   ##
==========================================
- Coverage   99.34%   99.34%   -0.01%     
==========================================
  Files        1921     1921              
  Lines      179504   179188     -316     
  Branches      898      895       -3     
==========================================
- Hits       178327   178011     -316     
  Misses       1121     1121              
  Partials       56       56
Impacted Files Coverage Δ
src/locales/pl/address/street_prefix.ts 100.00% <100.00%> (ø)
src/faker.ts 100.00% <0.00%> (ø)
src/definitions/definitions.ts 100.00% <0.00%> (ø)
src/locales/ar/name/male_first_name.ts 100.00% <0.00%> (ø)

@import-brain import-brain added the p: 1-normal Nothing urgent label Apr 19, 2022
@import-brain import-brain requested a review from a team April 19, 2022 02:17
@ST-DDT ST-DDT requested a review from a team April 19, 2022 08:22
@Shinigami92 Shinigami92 enabled auto-merge (squash) April 19, 2022 20:03
@Shinigami92 Shinigami92 merged commit 425accd into main Apr 19, 2022
@ST-DDT ST-DDT deleted the pl-street-prefix branch April 19, 2022 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@import-brain import-brain import-brain approved these changes

@prisis prisis prisis approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

Assignees

@pkuczynski pkuczynski

Labels
c: locale Permutes locale definitions p: 1-normal Nothing urgent
Projects
None yet
Milestone
v6.2 - New small features
Development

Successfully merging this pull request may close these issues.
5 participants
@pkuczynski @ST-DDT @prisis @import-brain @Shinigami92