Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide proper PacketType type / iota #12

Closed
3 tasks done
fako1024 opened this issue Mar 21, 2023 · 1 comment · Fixed by #13
Closed
3 tasks done

Provide proper PacketType type / iota #12

fako1024 opened this issue Mar 21, 2023 · 1 comment · Fixed by #13
Assignees
@fako1024
Labels
bug Something isn't working enhancement New feature or request
Milestone
Initial Release (v1)

Comments

@fako1024
Copy link
Owner

fako1024 commented Mar 21, 2023 •
edited
Loading

For readability it would be helpful to have an actual enum providing the same named packet type (a.k.a. direction w.r.t. interface) as provided by the linux kernel.

DoD

  • Add proper enum with human readable names
  • Check if current logic is actually correct (packetType == 0 for inbound)
  • Delete branch (got merged together with 7 implement mock capture source #14 without explicit review / approval)
@fako1024 fako1024 added the enhancement New feature or request label Mar 21, 2023
@fako1024 fako1024 self-assigned this Mar 21, 2023
@fako1024 fako1024 mentioned this issue Mar 21, 2023
Merged
@fako1024 fako1024 linked a pull request Mar 21, 2023 that will close this issue
Provide enum for packet type / direction and fix direction logic #13
Merged
@fako1024 fako1024 added the bug Something isn't working label Mar 21, 2023
@fako1024 fako1024 mentioned this issue Mar 21, 2023
Closed
2 tasks
@fako1024 fako1024 added this to the Initial Release (v1) milestone Mar 22, 2023
@fako1024
Copy link
Owner Author

Reopening because technically the PR wasn't seen / approved yet an the changes got merged automatically with #14 .

@fako1024 fako1024 reopened this Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fako1024 fako1024

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
Initial Release (v1)
Development

Successfully merging a pull request may close this issue.

Provide enum for packet type / direction and fix direction logic fako1024/slimcap
1 participant
@fako1024