Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize interface path traversal sanitization #56

Closed
fako1024 opened this issue Aug 21, 2023 · 0 comments · Fixed by #57
Closed

Optimize interface path traversal sanitization #56

fako1024 opened this issue Aug 21, 2023 · 0 comments · Fixed by #57
Assignees
@fako1024
Labels
enhancement New feature or request performance Performance / optimization related topics security Security / vulnerability related issues
Milestone
Initial Release (v1)

Comments

@fako1024
Copy link
Owner

Currently, when creating a new link / interface the code performs a duplicate path sanitization via filepath.Clean() (because it opens two files in the same directory), which is unnecessary. Instead, it would be better to sanitize the name of the interface once and then call the individual functions as methods (using the sanitized / stored name of the interface).
@fako1024 fako1024 added enhancement New feature or request performance Performance / optimization related topics security Security / vulnerability related issues labels Aug 21, 2023
@fako1024 fako1024 added this to the Initial Release (v1) milestone Aug 21, 2023
@fako1024 fako1024 self-assigned this Aug 21, 2023
@fako1024 fako1024 linked a pull request Aug 21, 2023 that will close this issue
[feature] Optimize path traversal sanitization for link / interface access #57
Merged
@fako1024 fako1024 mentioned this issue Aug 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fako1024 fako1024

Labels
enhancement New feature or request performance Performance / optimization related topics security Security / vulnerability related issues
Projects
None yet
Milestone
Initial Release (v1)
Development

Successfully merging a pull request may close this issue.

[feature] Optimize path traversal sanitization for link / interface access fako1024/slimcap
1 participant
@fako1024