Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align mock snaplen handling for pktHdr with reality #84

Closed
fako1024 opened this issue May 6, 2024 · 0 comments · Fixed by #85 or #86
Closed

Align mock snaplen handling for pktHdr with reality #84

fako1024 opened this issue May 6, 2024 · 0 comments · Fixed by #85 or #86
Assignees
@fako1024
Labels
bug Something isn't working

Comments

@fako1024
Copy link
Owner

fako1024 commented May 6, 2024

If actual packets are truncated / smaller than the defined capture snaplen, the snaplen value in the TPacket header is set to the length of the packet, not the snaplen (as it currently the case for the mock source). This usually isn't a problem (because it will just allocate more memory than actually required) but may miss issues that would occur on an "real" capture.
@fako1024 fako1024 added the bug Something isn't working label May 6, 2024
@fako1024 fako1024 self-assigned this May 6, 2024
@fako1024 fako1024 linked a pull request May 6, 2024 that will close this issue
[bugfix] Fix handling of mock snaplen field in pktHdr for packets smaller than snaplen #85
Merged
@fako1024 fako1024 mentioned this issue May 6, 2024
Merged
@fako1024 fako1024 reopened this May 6, 2024
@fako1024 fako1024 mentioned this issue May 6, 2024
Merged
@fako1024 fako1024 linked a pull request May 6, 2024 that will close this issue
[bugfix] Fix handling of mock snaplen field in pktHdr for packets smaller than snaplen #86
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fako1024 fako1024

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@fako1024