Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Falco version #1039

Closed
leodido opened this issue Feb 5, 2020 · 1 comment · Fixed by #872
Closed

Fix the Falco version #1039

leodido opened this issue Feb 5, 2020 · 1 comment · Fixed by #872
Assignees
Labels

Comments

@leodido
Copy link
Member

leodido commented Feb 5, 2020

Describe the bug

Currently, when Falco builds, the cmake computes its version looking at the git index.

At the moment, cmake outputs version with an unwanted leading 0.

How to reproduce it

mkdir -p build
cd build
cmake ..

Look at the cmake output.

Expected behaviour

...
-- Falco version: 0.19.0+e1a753f
...

Screenshots

...
-- Falco version: 0.0.19.0+e1a753f
...
@leodido
Copy link
Member Author

leodido commented Feb 6, 2020

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant