fix for GitHub issue 112. 'echo Foo|ack Bar' will now return 1 instea…

…d of 0 (as indicated by the manpage, and as is consistent with ack's non-stdin based behavior)
fallwith · Feb 21, 2010 · 20d372e · 20d372e · petdance · Sep 5, 2010
1 parent 9555698
commit 20d372e
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/ack b/ack
@@ -70,9 +70,9 @@ sub main {
             App::Ack::warn( "Ignoring $nargs argument$s on the command-line while acting as a filter." );
         }
         my $res = App::Ack::Resource::Basic->new( '-' );
-        App::Ack::search_resource( $res, $opt );
+        my $nmatches = App::Ack::search_resource( $res, $opt );
         $res->close();
-        exit 0;
+        $nmatches ? exit 0 : exit 1;
     }
 
     my $file_matching = $opt->{f} || $opt->{lines};

diff --git a/ack-base b/ack-base
@@ -62,9 +62,9 @@ sub main {
             App::Ack::warn( "Ignoring $nargs argument$s on the command-line while acting as a filter." );
         }
         my $res = App::Ack::Resource::Basic->new( '-' );
-        App::Ack::search_resource( $res, $opt );
+        my $nmatches = App::Ack::search_resource( $res, $opt );
         $res->close();
-        exit 0;
+        $nmatches ? exit 0 : exit 1;
     }
 
     my $file_matching = $opt->{f} || $opt->{lines};

diff --git a/btg/ack-standalone b/btg/ack-standalone
@@ -70,9 +70,9 @@ sub main {
             App::Ack::warn( "Ignoring $nargs argument$s on the command-line while acting as a filter." );
         }
         my $res = App::Ack::Resource::Basic->new( '-' );
-        App::Ack::search_resource( $res, $opt );
+        my $nmatches = App::Ack::search_resource( $res, $opt );
         $res->close();
-        exit 0;
+        $nmatches ? exit 0 : exit 1;
     }
 
     my $file_matching = $opt->{f} || $opt->{lines};