Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

[Feature] Tabline support #169

Closed
jlesquembre opened this issue Nov 17, 2021 · 7 comments
Closed

[Feature] Tabline support #169

jlesquembre opened this issue Nov 17, 2021 · 7 comments
Labels
kind: feature New feature or request

Comments

@jlesquembre
Copy link

Is your feature request related to a problem? Please describe.
It would be nice if it had support for tabline, to make the statusline and the tabline consistent.

Additional context
I found this discussion about the same topic for galaxyline: nvimdev/galaxyline.nvim#24
I fully agree with this comment: nvimdev/galaxyline.nvim#24 (comment)

And thanks for feline.nvim, it's a great plugin, my neovim looks a lot better thanks to it :)

@jlesquembre jlesquembre added the kind: feature New feature or request label Nov 17, 2021
@FrenzyExists
Copy link

So uh, lets see if I can understand this, you mean that feline could also be a tabline? As in tapping this thingy?

image

@jlesquembre
Copy link
Author

@FrenzyExists yes, I'd like to customize what I can see on that screenshot, the tabline.

feline currently offers a nice api to customize the statusline, it'd be great to be able to use the same api to customize the tabline too

@FrenzyExists
Copy link

FrenzyExists commented Nov 24, 2021

I've been checking the code in feline (note, I don't exactly know lua that much), and decided to also check akinsho's bufferline code. I think that lilke, maybe 1/4th of the utils from bufferline code from there could just be yoinked into feline, which is pretty much the clickable functions, the functions that comunicate with neovim's buffer and tabs, and the close button.

i think i gonna prolly play with the api, kinda like the idea of having both bufferline and tabline in a single plugin

@famiu
Copy link
Owner

famiu commented Nov 27, 2021

I'm not sure how to handle the tabline click events, so I'd have to look into it. A PR would also be very welcome.

@ram02z
Copy link
Contributor

ram02z commented Jan 27, 2022

Tabline click events require using a vim function.

This is how bufferline.nvim handles it: https://github.com/akinsho/bufferline.nvim/blob/master/autoload/nvim_bufferline.vim

@famiu famiu added priority: medium Has medium priority and removed priority: medium Has medium priority labels Feb 11, 2022
@famiu
Copy link
Owner

famiu commented Feb 13, 2022

It seems adding tabline support is much more complicated than it sounds and would require too much change to the original codebase and documentation to be worth the hassle. Besides, there's already quite a few good tabline plugins, so I'd just recommend using those. I'd like Feline to stick with the Unix philosophy of doing one thing and doing it well.

@famiu famiu closed this as completed Feb 13, 2022
@tummetott
Copy link
Contributor

What a pitty. Feline is by far the best statusline plugin out there, the APi is just on point. The tabline plugins I know are:
barbar, bufferline, tabby and nvim-tabline. I tried them all and they have all their flaws. Anyway, I understand your decision, just wanted to note that configuring the tabline with the feline API would be a blast.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind: feature New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants