Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An error of poses_diff() function #6

Closed
muxizju opened this issue Nov 1, 2019 · 6 comments
Closed

An error of poses_diff() function #6

muxizju opened this issue Nov 1, 2019 · 6 comments

Comments

@muxizju
Copy link

muxizju commented Nov 1, 2019

def poses_diff(x):
    H, W = x.get_shape()[1], x.get_shape()[2]
    x = tf.subtract(x[:, :1, ...], x[:, :-1, ...])
    x = tf.image.resize_nearest_neighbor(x, size=[H.value, W.value], align_corners=False)  # should not alignment here
    return x

the subtract operation subtract x[:, :1, ...] and x[:, :-1, ...], while the first input might be wrong, it should be x[:, 1:, ...]. Current operation in fact subtract the first postion for all frames with array broadcast.

I have test that train the lite network on SHREC coarse data, the acc of validation is almost the same while the acc of training dataset is lower than validation. Which might be the reason of too much dropout. There might be still some space for improving.

If I'm wrong, please let me know

@pengfeiZhao1993
Copy link

yes, I also find this error, after fixing it , the accuracy gets better.

@fandulu
Copy link
Owner

fandulu commented Nov 9, 2019

Thanks very much for pointing out this issue. I had corrected them in the current version. As both of you had mentioned, such a correction did an improvement in SHREC data (for coarse data: It was improved from 94.6 to 94.8 with 1.82M parameters and from 91.8 to 94.1 with 0.15M parameters).

@muxizju
Copy link
Author

muxizju commented Nov 15, 2019

Thanks very much for pointing out this issue. I had corrected them in the current version. As both of you had mentioned, such a correction did an improvement in SHREC data (for coarse data: It was improved from 94.6 to 94.8 with 1.82M parameters and from 91.8 to 94.1 with 0.15M parameters).

great job! very fast and high accuracy. And have you ever tried this model on other dataset ,especially the NTU RGB+D dataset. which is very hot for skeleton based action recognition. and how is the performance

@fandulu
Copy link
Owner

fandulu commented Nov 22, 2019

Sorry, I may not try it since the skeleton contains much noise and loses context information, it is not as good as only using RGB in body action recognition and I stop further investigate it. This work was originally designed for hand gesture as we could obtain a more accurate 3D hand pose and it may not be related to context information. If you are working on NTU, stacking more modules (e.g., 2s-AGCN) might help to boost the performance of NTU up to ~96+(CV) and ~90+(CS).

@fandulu fandulu closed this as completed Nov 29, 2019
@PrinceP
Copy link

PrinceP commented Jan 18, 2020

@pengfeiZhao1993 @muxizju Can you please explain how to run the SHREC dataset.

@PrinceP
Copy link

PrinceP commented Jan 18, 2020

Got it! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants