Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respin does not seem to generate random numbers correctly #33

Closed
kel85uk opened this issue Mar 30, 2018 · 2 comments
Closed

Respin does not seem to generate random numbers correctly #33

kel85uk opened this issue Mar 30, 2018 · 2 comments

Comments

@kel85uk
Copy link

kel85uk commented Mar 30, 2018

Hi, I seem to have problems with using respin, in that, the reflectance obtained with Nphotons = 1E7, respin = 1, is different from say, Nphotons = 1e7, respin = 10.

@fangq
Copy link
Owner

fangq commented May 25, 2018

@kel85uk, recently, I modified the respin parameter so that 1) when respin number is positive, it serves as a multiplier (for example nphoton=1e7 and respin=10 will give you total 1e8 photon, with 1e7 per batch); 2) when respin number is negative, it serves as a divider (for example, nphoton=1e7 and respin=-10 will output a total of 1e7 photons, with 1e6 per batch).

7f1b574

can you retest the latest respin parameter and let me know if this issue still present? if it does, can you give me a script so that I can reproduce the issue?

download the latest binary from

http://mcx.space/

thanks

@fangq
Copy link
Owner

fangq commented Sep 3, 2018

I am closing this ticket. if the issue remains, feel free to reopen.

@fangq fangq closed this as completed Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants