Skip to content

Commit

Permalink
chore: add deno.inlayHints.* configurations
Browse files Browse the repository at this point in the history
  • Loading branch information
@fannheyward
fannheyward committed Oct 18, 2022
1 parent 66e3fd0 commit 2492c9a
Showing 1 changed file with 58 additions and 0 deletions.
58 changes: 58 additions & 0 deletions package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,64 @@
"C:\\path\\to\\deno.jsonc"
]
},
"deno.inlayHints.parameterNames.enabled": {
"type": "string",
"enum": [
"none",
"literals",
"all"
],
"enumDescriptions": [
"Disable inlay hints for parameters.",
"Display inlay hints for literal arguments.",
"Display inlay hints for all literal and non-literal arguments."
],
"default": "none",
"markdownDescription": "Enable/disable inlay hints for parameter names.",
"scope": "resource"
},
"deno.inlayHints.parameterNames.suppressWhenArgumentMatchesName": {
"type": "boolean",
"default": true,
"markdownDescription": "Do not display an inlay hint when the argument name matches the parameter.",
"scope": "resource"
},
"deno.inlayHints.parameterTypes.enabled": {
"type": "boolean",
"default": false,
"markdownDescription": "Enable/disable inlay hints for implicit parameter types.",
"scope": "resource"
},
"deno.inlayHints.variableTypes.enabled": {
"type": "boolean",
"default": false,
"markdownDescription": "Enable/disable inlay hints for implicit variable types.",
"scope": "resource"
},
"deno.inlayHints.variableTypes.suppressWhenTypeMatchesName": {
"type": "boolean",
"default": true,
"markdownDescription": "Suppress type hints where the variable name matches the implicit type.",
"scope": "resource"
},
"deno.inlayHints.propertyDeclarationTypes.enabled": {
"type": "boolean",
"default": false,
"markdownDescription": "Enable/disable inlay hints for implicit property declarations.",
"scope": "resource"
},
"deno.inlayHints.functionLikeReturnTypes.enabled": {
"type": "boolean",
"default": false,
"markdownDescription": "Enable/disable inlay hints for implicit function return types.",
"scope": "resource"
},
"deno.inlayHints.enumMemberValues.enabled": {
"type": "boolean",
"default": false,
"markdownDescription": "Enable/disable inlay hints for enum values.",
"scope": "resource"
},
"deno.importMap": {
"type": "string",
"default": null,
Expand Down

8 comments on commit 2492c9a

@yaegassy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fannheyward Did deno's inlay hints work correctly in fann's environment?

@fannheyward
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs Deno 1.27, not released yet. I shouldn't release these configurations now, just a mistake.

@fannheyward
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

denoland/deno#16287

@yaegassy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I built and tested deno itself.

I have a strange situation in my environment where once I edit the settings of a section of deno.* the results are returned with inlay hints. This was the same behavior in vscode_deno.

coc-deno-inlay-hints-check.mp4

@yaegassy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope this will not be a problem when deno v1.27.0 is released...

By the way, vim-lsp works as it is just by passing the settings. I haven't done anything unusual on the vim-lsp side...

vim-lsp:

vim-lsp-deno-inlay-hint.mp4

@fannheyward
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yaegassy try coc-deno master

@yaegassy
Copy link
Contributor

@yaegassy yaegassy commented on 2492c9a Oct 19, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fannheyward It work fine. I am relieved!

Kapture.2022-10-19.at.12.45.46.mp4

@fannheyward
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v3.10.4 Released

Please sign in to comment.