Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST] Consider hiding the item piles button in the sheet header #56

Closed
mech-tools opened this issue Feb 10, 2022 · 8 comments
Closed
Labels
enhancement New feature or request

Comments

@mech-tools
Copy link

Is your feature request related to a problem? Please describe.
The new sharing feature is very cool.
But that is the only feature I want to use, and my sheet headers are really bloated.

Describe the solution you'd like
Is it possible to deactivate completely the item piles feature and not have the button displayed in the sheet headers?

@mech-tools mech-tools added the enhancement New feature or request label Feb 10, 2022
@Haxxer
Copy link
Collaborator

Haxxer commented Feb 10, 2022

This is already a setting in the module settings.

@Haxxer Haxxer closed this as completed Feb 10, 2022
@mech-tools
Copy link
Author

@Haxxer Then it's not working cause the icon is still showing up:
image

@Haxxer
Copy link
Collaborator

Haxxer commented Feb 10, 2022

Oh, you want to hide the entirety of the icon? How would you configure item piles in the actors bar?

@mech-tools
Copy link
Author

mech-tools commented Feb 10, 2022

Someone didn't read the initial ticket 😸
I don't want to use the core features of this module, only the very cool trading window (that could have been its own module imo)

@Haxxer
Copy link
Collaborator

Haxxer commented Feb 10, 2022

My apologies - the trading system is heavily integrated into the item pile system, so splitting them would be hard to say the least. I'll see about adding togglable settings for each sub-system.

@mech-tools
Copy link
Author

Great! Should I open a new ticket about adding togglable settings for each sub-system or do you reopen this ticket?

@Haxxer Haxxer reopened this Feb 10, 2022
@Haxxer
Copy link
Collaborator

Haxxer commented Feb 10, 2022

The item piles module is completely open source, so feel free to submit a PR with how you'd like this to work :)

@Haxxer Haxxer removed their assignment Sep 22, 2022
@Haxxer
Copy link
Collaborator

Haxxer commented Nov 26, 2022

Added option in 2.3.3

@Haxxer Haxxer closed this as completed Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants