Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

probable starting and ending year data columns #2

Closed
kramera3 opened this issue Oct 9, 2020 · 1 comment
Closed

probable starting and ending year data columns #2

kramera3 opened this issue Oct 9, 2020 · 1 comment

Comments

@kramera3
Copy link
Collaborator

kramera3 commented Oct 9, 2020

I have added an error check for missing values when expandYearlyCosts is used. In doing this I found that only "Probable_starting_year_low_margin" and "Probable_ending_year_low_margin" have complete data. "Probable_...year" and "Probable..._year_high_margin" do not. Not sure if this should be part of the response to the user (i.e. explain why the data are missing).
@Farewe
Copy link
Owner

Farewe commented Nov 3, 2020

Yes, this is good. I have updated the error message to suggest using the "low margin" and "high margin" columns. I have added a note in the help file with info on this aspect.

@Farewe Farewe closed this as completed Nov 3, 2020
Farewe added a commit that referenced this issue Mar 4, 2022
@Farewe
Updates to the tutorial for revision of the invacost package paper #2
9ba38a4
Farewe added a commit that referenced this issue Mar 4, 2022
@Farewe
Update tutorial for invacost revision #2
6031b75 
Merge branch 'master' of https://github.com/Farewe/invacost

# Conflicts:
#	Readme.Rmd
#	Readme.md
#	Readme_files/figure-gfm/models2-1.png
#	Readme_files/figure-gfm/models52-1.png
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Farewe @kramera3