Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency node-sass is deprecated #3

Closed
farooqkz opened this issue Dec 2, 2022 · 4 comments
Closed

Dependency node-sass is deprecated #3

farooqkz opened this issue Dec 2, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@farooqkz
Copy link
Owner

farooqkz commented Dec 2, 2022

According to https://www.npmjs.com/package/node-sass it will still receive maintenance updates. But in long term, we'll have to move to something else.

@farooqkz farooqkz added the enhancement New feature or request label Dec 2, 2022
@Simon-Laux
Copy link
Collaborator

the new way to use sass is https://github.com/sass/dart-sass afaik.

npm install --save-dev sass

@farooqkz
Copy link
Owner Author

Can you send a PR? @Simon-Laux

@Simon-Laux
Copy link
Collaborator

npm install --save-dev sass?

At the moment I don't see where node-sass is called currently in this repo, so I can not really replace it's usage.

After looking inside of chooj source I conclude that you could just remove node-sass as it was never really used here. chooj imports the scss file and it's bundler (parcel) compiles it.

@farooqkz
Copy link
Owner Author

npm install --save-dev sass?

At the moment I don't see where node-sass is called currently in this repo, so I can not really replace it's usage.

After looking inside of chooj source I conclude that you could just remove node-sass as it was never really used here. chooj imports the scss file and it's bundler (parcel) compiles it.

yeah you are right. there is no dependency now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants