Adds scarf prefix to init and airbyte/metabase m1 images #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tovbinm
approved these changes
May 3, 2022
docker-compose.yaml
Outdated
| @@ -47,7 +47,7 @@ services: | |||
| restart: unless-stopped | |||
| faros-init: | |||
| profiles: ["default", "faros-init"] | |||
| image: farosai/faros-ce-init:latest | |||
| image: farosai.docker.scarf.sh/farosai/faros-ce-init:latest | |||
There was a problem hiding this comment.
did we want to use our own domain name @tovbinm @ypc-faros ?
There was a problem hiding this comment.
No, we tried. This is easier to use as well.
There was a problem hiding this comment.
would it be possible to parametrize this in start.sh to keep the docker-compose scarf-free? could make sense since start.sh deals with telemetry already.
There was a problem hiding this comment.
Makes sense. if you think it can be useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds scarf prefix to init and airbyte/metabase m1 images
Type of change
(Delete what does not apply)
Checklist
(Delete what does not apply)