Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds scarf prefix to init and airbyte/metabase m1 images #126

Merged
merged 6 commits into from
May 4, 2022
Merged

Adds scarf prefix to init and airbyte/metabase m1 images #126

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e1dc8f7
Adds scarf prefix to init and airbyte/metabase m1 images
ypc-faros May 3, 2022
e9e9694
Undo wget
ypc-faros May 3, 2022
4dd3724
Merge branch 'main' into ypc/scarf
tovbinm May 4, 2022
caa48a1
Merge branch 'main' into ypc/scarf
tovbinm May 4, 2022
10fe6ef
Add FAROS_INIT_IMAGE env var
ypc-faros May 4, 2022
0ff2ae7
Merge branch 'ypc/scarf' of https://github.com/faros-ai/faros-communi…
ypc-faros May 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion docker-compose.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ services:
restart: unless-stopped
faros-init:
profiles: ["default", "faros-init"]
image: farosai/faros-ce-init:latest
image: farosai.docker.scarf.sh/farosai/faros-ce-init:latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did we want to use our own domain name @tovbinm @ypc-faros ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we tried. This is easier to use as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be possible to parametrize this in start.sh to keep the docker-compose scarf-free? could make sense since start.sh deals with telemetry already.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. if you think it can be useful.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

restart: on-failure
environment:
AIRBYTE_API_CALLS_CONCURRENCY: ${AIRBYTE_API_CALLS_CONCURRENCY:-}
Expand Down
3 changes: 2 additions & 1 deletion start.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@ docker-compose pull faros-init

if [[ $(uname -m 2> /dev/null) == 'arm64' ]]; then
# Use Airbyte and Metabase images built for Apple M1
AIRBYTE_IMAGE_PREFIX="farosai/airbyte-" METABASE_IMAGE="farosai/metabase-m1" docker-compose up --build --remove-orphans
AIRBYTE_IMAGE_PREFIX="farosai.docker.scarf.sh/farosai/airbyte-" METABASE_IMAGE="farosai.docker.scarf.sh/farosai/metabase-m1" \
docker-compose up --build --remove-orphans
else
docker-compose up --build --remove-orphans
fi
Expand Down