Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Size can be string #10

Closed
cagataysayg opened this issue Mar 25, 2022 · 5 comments
Closed

Size can be string #10

cagataysayg opened this issue Mar 25, 2022 · 5 comments

Comments

@cagataysayg
Copy link

Size type declared as number but it can be string too. For example, it can be one of those px, vh, vw etc.

image
@Farzin-Firoozi
Copy link
Owner

If you want to do that you can pass width to the style prop and it overwrites the size.

<Drawer style={{ width: '50vw' }} >
...

take a look at this.

@cagataysayg
Copy link
Author

That's how I already did it but I just wanted to improve the code.

@Farzin-Firoozi
Copy link
Owner

Can you make a PR for it?

@cagataysayg
Copy link
Author

Need access to create a branch

@Farzin-Firoozi
Copy link
Owner

Farzin-Firoozi commented Mar 26, 2022 •
edited
Loading

This feature is available now in v1.1.0! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cagataysayg @Farzin-Firoozi