Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: translation of sound names makes the sound files inaccessible #900

Closed
pmjherman opened this issue Mar 22, 2023 · 1 comment · Fixed by #901
Closed

BUG: translation of sound names makes the sound files inaccessible #900

pmjherman opened this issue Mar 22, 2023 · 1 comment · Fixed by #901
Labels

Comments

@pmjherman
Copy link
Contributor

pmjherman commented Mar 22, 2023

In the preferences dialog, the user can choose a sound that is produced when selecting an object into a piece. The names of the sounds are also the names of the files with the sound. When the names are translated, the files can no longer be found and a warning comes. This warning is flagged with every point selected.
The bug only appears when the language file is (nearly) complete. This is the case for Dutch nl_NL
Solution is to make the names of the sound non-translatable. It is no problem if the user does not understand the description, as one can hear the sound when selecting.
The problem existed already for some time. Last tested on a fresh build based on yesterday's code.
See my PR for a simple solution to the problem

@pmjherman pmjherman added the bug label Mar 22, 2023
@DSCaskey
Copy link
Contributor

DSCaskey commented Mar 22, 2023

Good catch.

Creator enables translations by default. Guess I'll have to be more aware of that in the future.

@DSCaskey DSCaskey linked a pull request Mar 22, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants