Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve combiner overflow behavior #348

Closed
Dragorn421 opened this issue May 20, 2024 · 3 comments · Fixed by #354
Closed

Improve combiner overflow behavior #348

Dragorn421 opened this issue May 20, 2024 · 3 comments · Fixed by #354
Assignees
Milestone

Comments

@Dragorn421
Copy link
Contributor

#335 (tried to) improve combiner overflow behavior

but we had to revert it due to breaking preview of other things #347

So that improvement is back on the table

@jesusyoshi54
Copy link
Collaborator

So basically the comber C input overflows >= 256, which is only on the 1.0 input, the others are 255 max. I didn't account for this the second time i edited the nodes woopsie.
Somehow I didn't see this when I tested because I only tested that the aberrant behavior was fixed not that all manner of normal behavior still worked.

@Lilaa3
Copy link
Collaborator

Lilaa3 commented May 20, 2024

I only checked the nodes and tested the behavior on a simple black and white material so this is partly my fault, I will try out scenes in any future f3d rendering related PRs, sorry about this.

@jesusyoshi54 jesusyoshi54 added this to the v2.2.2 milestone May 26, 2024
@jesusyoshi54
Copy link
Collaborator

Can someone post some of the combiners of the broken materials shown in #347 I can't quite recreate the extent with which things get messed up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants