Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[F3D] Cmd size not taken into account when creating tile scroll offsets #416

Closed
jesusyoshi54 opened this issue Aug 11, 2024 · 3 comments
Closed

[F3D] Cmd size not taken into account when creating tile scroll offsets #416

jesusyoshi54 opened this issue Aug 11, 2024 · 3 comments
Labels
bug Something isn't working f3d Has to do with the "f3d" code common to all games

Comments

@jesusyoshi54
Copy link
Collaborator

jesusyoshi54 commented Aug 11, 2024 •
edited
Loading

For example gsSPLightColor will increment DL length by one, when it is actually 2 cmds.
Causes tile scrolling to affect the wrong display list cmds leading to graphical glitches

it seems to only affect gsSPLightColor from my testing but there may be other forgotten cmds
@Dragorn421
Copy link
Contributor

Fixed by #419 ? @jesusyoshi54

@Dragorn421 Dragorn421 added bug Something isn't working f3d Has to do with the "f3d" code common to all games labels Aug 22, 2024
@Lilaa3
Copy link
Collaborator

Lilaa3 commented Aug 22, 2024

I inspected all commands so I'd say it is fixed

@Dragorn421
Copy link
Contributor

Fixed by #419

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working f3d Has to do with the "f3d" code common to all games
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Dragorn421 @jesusyoshi54 @Lilaa3