New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor typo in Stable Diffusion Deep Dive notebook #9

Closed

daspartho opened this issue Oct 15, 2022 · 1 comment

daspartho commented Oct 15, 2022 •

edited

Loading

Hi, @johnowhitaker

In the positional embedding section at the line

But now instead of dealing with ~50 tokens we just need one for each position (77 total):

I think the number of tokens should be 50K instead of 50. Could you please confirm this?

Thanks

Collaborator

johnowhitaker commented Oct 18, 2022

You're right that should be 50K - I'll change that along with one or two other tweaks soon.Thanks :)

daspartho closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment