Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] CMake option to use system-provided yyjson #525

Closed
FedericoSchonborn opened this issue Aug 18, 2023 · 1 comment
Closed
Labels
enhancement New feature or request

Comments

@FedericoSchonborn
Copy link

Current state:

yyjson is downloaded during the build step (and vendored as of cd4a512), and there's no option to use the system-provided version of the library. Gentoo has a patch that removes the download step to use the system-provided yyjson instead.

Wanted state:

An option to use the system-provided yyjson should be available in CMake or the download/vendoring should be disabled if a system-provided version of yyjson is found.

Why the change is sensible:

Many Linux distributions would benefit from this feature, as they usually want to avoid enabling networking during builds and vendored libraries.

@FedericoSchonborn FedericoSchonborn added the enhancement New feature or request label Aug 18, 2023
@FedericoSchonborn FedericoSchonborn changed the title [Feature Request]: Option to use system-provided yyjson [Feature Request] CMake option to use system-provided yyjson Aug 18, 2023
@CarterLi
Copy link
Member

Hello.

Fastfetch v2.0.1 has been released, with -DENABLE_SYSTEM_YYJSON support. Please check it.

Also please check if the terminal detection is correctly fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants