Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add internalRewriteLocationHeader option #298

Merged
merged 3 commits into from
May 2, 2023
Merged

feat: add internalRewriteLocationHeader option #298

merged 3 commits into from
May 2, 2023

Conversation

efr00
Copy link
Contributor

@efr00 efr00 commented Apr 12, 2023 •
edited by mcollina
Loading

fixes: #296

Checklist

@efr00 efr00 mentioned this pull request Apr 12, 2023
Closed
2 tasks
Eomm
Eomm reviewed Apr 13, 2023
View reviewed changes
test/test.js Outdated Show resolved Hide resolved
mcollina
mcollina requested changes Apr 14, 2023
View reviewed changes
README.md Outdated
@@ -163,6 +163,14 @@ configuration passed to the route.

Object with [reply options](https://github.com/fastify/fastify-reply-from#replyfromsource-opts) for `@fastify/reply-from`.

### `disableInternalRewriteLocationHeader`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use a positive option instead (defaulted to true)? Something like internalRewriteLocationHeader.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I will do it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's done

@efr00 efr00 requested a review from mcollina May 2, 2023 14:37
@mcollina mcollina changed the title feat: add disableInternalRewriteLocationHeader option feat: add internalRewriteLocationHeader option May 2, 2023
mcollina
mcollina approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 156125d into fastify:master May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@Eomm Eomm Eomm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

location headers is rewritten without the possibility to disable this behavior
3 participants
@efr00 @mcollina @Eomm