Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WebSocket host constraints #332

Merged
merged 3 commits into from
Jan 30, 2024
Merged

Conversation

valeneiko
Copy link
Contributor

Fixes 2 issues:

  • mismatch between Http and WebSocket routing
    • WebSockets now support constraints
    • WebSockets now use the same path rewriting logic as Http
  • wsServerOptions are now distinct for each WebSocket proxy

Fixes: #206

Checklist

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 916d85c into fastify:master Jan 30, 2024
19 checks passed
renovate bot added a commit to redwoodjs/redwood that referenced this pull request Mar 7, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@fastify/http-proxy](https://togithub.com/fastify/fastify-http-proxy)
| [`9.3.0` ->
`9.4.0`](https://renovatebot.com/diffs/npm/@fastify%2fhttp-proxy/9.3.0/9.4.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@fastify%2fhttp-proxy/9.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@fastify%2fhttp-proxy/9.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@fastify%2fhttp-proxy/9.3.0/9.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@fastify%2fhttp-proxy/9.3.0/9.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>fastify/fastify-http-proxy
(@&#8203;fastify/http-proxy)</summary>

###
[`v9.4.0`](https://togithub.com/fastify/fastify-http-proxy/releases/tag/v9.4.0)

[Compare
Source](https://togithub.com/fastify/fastify-http-proxy/compare/v9.3.0...v9.4.0)

#### What's Changed

- build(deps-dev): bump tsd from 0.29.0 to 0.30.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[fastify/fastify-http-proxy#328
- chore: replace `fastify.io` links with `fastify.dev` by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[fastify/fastify-http-proxy#331
- Add WebSocket host constraints by
[@&#8203;valeneiko](https://togithub.com/valeneiko) in
[fastify/fastify-http-proxy#332

#### New Contributors

- [@&#8203;valeneiko](https://togithub.com/valeneiko) made their first
contribution in
[fastify/fastify-http-proxy#332

**Full Changelog**:
fastify/fastify-http-proxy@v9.3.0...v9.4.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/redwoodjs/redwood).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMjAuMiIsInVwZGF0ZWRJblZlciI6IjM3LjIyNy4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Dominic Saadi <dominiceliassaadi@gmail.com>
jtoar added a commit to redwoodjs/redwood that referenced this pull request Mar 7, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@fastify/http-proxy](https://togithub.com/fastify/fastify-http-proxy)
| [`9.3.0` ->
`9.4.0`](https://renovatebot.com/diffs/npm/@fastify%2fhttp-proxy/9.3.0/9.4.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@fastify%2fhttp-proxy/9.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@fastify%2fhttp-proxy/9.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@fastify%2fhttp-proxy/9.3.0/9.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@fastify%2fhttp-proxy/9.3.0/9.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>fastify/fastify-http-proxy
(@&#8203;fastify/http-proxy)</summary>

###
[`v9.4.0`](https://togithub.com/fastify/fastify-http-proxy/releases/tag/v9.4.0)

[Compare
Source](https://togithub.com/fastify/fastify-http-proxy/compare/v9.3.0...v9.4.0)

#### What's Changed

- build(deps-dev): bump tsd from 0.29.0 to 0.30.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[fastify/fastify-http-proxy#328
- chore: replace `fastify.io` links with `fastify.dev` by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[fastify/fastify-http-proxy#331
- Add WebSocket host constraints by
[@&#8203;valeneiko](https://togithub.com/valeneiko) in
[fastify/fastify-http-proxy#332

#### New Contributors

- [@&#8203;valeneiko](https://togithub.com/valeneiko) made their first
contribution in
[fastify/fastify-http-proxy#332

**Full Changelog**:
fastify/fastify-http-proxy@v9.3.0...v9.4.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/redwoodjs/redwood).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMjAuMiIsInVwZGF0ZWRJblZlciI6IjM3LjIyNy4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Dominic Saadi <dominiceliassaadi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can register proxy by host
2 participants