-
-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: joi transform #374
fix: joi transform #374
Conversation
actually, the issue was with the used transformation lib changed to one which is updated more recently
Can you please add a test with this new lib as well? Line 43 in 9ec48ec
|
ref github.com//pull/144#issuecomment-456106235
I think a documentation is needed for |
@climba03003 feel free to add on this PR. However I think it is better to have a lib which supports latest |
Pull Request Test Coverage Report for Build 617305534
💛 - Coveralls |
Pull Request Test Coverage Report for Build 617461435
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind to add a full example for joi
in examples
folder?
@climba03003 example in #377 |
Thanks for your works. |
actually, the issue was with the used transformation lib
changed to one which is updated more recently
closes #373
Checklist
npm run test
andnpm run benchmark
and the Code of conduct