Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: joi transform #374

Merged
merged 6 commits into from
Mar 4, 2021
Merged

fix: joi transform #374

merged 6 commits into from
Mar 4, 2021

Conversation

alexanderniebuhr
Copy link
Contributor

actually, the issue was with the used transformation lib
changed to one which is updated more recently
closes #373

Checklist

actually, the issue was with the used transformation lib
changed to one which is updated more recently
@mcollina
Copy link
Member

mcollina commented Mar 3, 2021

Can you please add a test with this new lib as well?

"joi-to-json-schema": "^5.1.0",

@climba03003
Copy link
Member

climba03003 commented Mar 3, 2021

I think a documentation is needed for joi
joi-to-json-schema can be use before this commit and it suppose to be < 16.0.0
joi-to-json only support what it state.

@alexanderniebuhr
Copy link
Contributor Author

@climba03003 feel free to add on this PR. However I think it is better to have a lib which supports latest joi..

@coveralls
Copy link

Pull Request Test Coverage Report for Build 617305534

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 617156967: 0.0%
Covered Lines: 457
Relevant Lines: 457

💛 - Coveralls

@coveralls
Copy link

coveralls commented Mar 3, 2021

Pull Request Test Coverage Report for Build 617461435

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 617156967: 0.0%
Covered Lines: 457
Relevant Lines: 457

💛 - Coveralls

README.md Outdated Show resolved Hide resolved
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina requested a review from Eomm March 3, 2021 14:47
Copy link
Member

@climba03003 climba03003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind to add a full example for joi in examples folder?

@alexanderniebuhr
Copy link
Contributor Author

@climba03003 example in #377

@climba03003
Copy link
Member

@climba03003 example in #377

Thanks for your works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

transform joi to json not working with latest fastify
4 participants