Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reply handling #3099

Closed
climba03003 opened this issue May 26, 2021 · 5 comments 路 Fixed by #3100
Closed

reply handling #3099

climba03003 opened this issue May 26, 2021 · 5 comments 路 Fixed by #3100

Comments

@climba03003
Copy link
Member

climba03003 commented May 26, 2021 •
edited

馃挜 Regression Report

I think it should be related to the reply simplification.
fastify/fastify-nextjs#260

Not sure if it is only test case related only or production related. I am not using this plugin but it is worth knowing the test is currently failed.

Last working version

Worked up to version: 3.15.1

Stopped working in version: 3.16.1
@mcollina
Copy link
Member

mcollina commented May 26, 2021 •
edited

Sigh, I suspected this will happen. I'll issue a revert asap.

@mcollina
Copy link
Member

Confirmed, the change is semver-major.

@climba03003
Copy link
Member Author

climba03003 commented May 26, 2021 •
edited

@mcollina One more to revert 212fdb7

mcollina added a commit that referenced this issue May 26, 2021
@mcollina
fix #3099
2e86ba1
@mcollina mcollina mentioned this issue May 26, 2021
Merged
3 tasks
@mcollina
Copy link
Member

@climba03003 I actually went for a better solution, I fixed the underlining issue and make Next.js tests passing again.

@mcollina
Copy link
Member

check out #3099

mcollina added a commit that referenced this issue May 26, 2021
@mcollina
fix #3099 (#3100)
a848b0f
mcollina added a commit that referenced this issue May 29, 2021
@mcollina
Revert "fix #3099 (#3100)"
4346d9a 
This reverts commit a848b0f.
mcollina added a commit that referenced this issue May 29, 2021
@mcollina
Revert sent refactoring (#3108)
c566292 
* Revert "fix #3099 (#3100)"

This reverts commit a848b0f.

* Revert "fixup! Simplify reply sent monitoring (#3072) (#3079)"

This reverts commit 9bf6a33.

* Revert "Simplify reply sent monitoring (#3072)"

This reverts commit 212fdb7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #3099 fastify/fastify
2 participants
@mcollina @climba03003