Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #3099 #3100

Merged
merged 1 commit into from
May 26, 2021
Merged

fix #3099 #3100

merged 1 commit into from
May 26, 2021

Conversation

mcollina
Copy link
Member

Fixes #3099

Checklist

@mcollina mcollina requested a review from Eomm May 26, 2021 07:42
@mcollina
Copy link
Member Author

cc @climba03003

@mcollina
Copy link
Member Author

cc @sergiz

climba03003
climba03003 approved these changes May 26, 2021
View reviewed changes
Copy link
Member

@climba03003 climba03003 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have run the test for fastify-nextjs against the fix. It resolve the issue. LGTM.

@mcollina mcollina merged commit a848b0f into main May 26, 2021
@mcollina mcollina deleted the fix-3099 branch May 26, 2021 08:02
@sergejostir
Copy link
Contributor

LGTM. The this.sent check is kinda redundant now since the whole condition cannot be true without this[kReplySentOverwritten] being true (and when it is true, this.sent will be true as well).

mcollina added a commit that referenced this pull request May 29, 2021
@mcollina
Revert "fix #3099 (#3100)"
4346d9a 
This reverts commit a848b0f.
mcollina added a commit that referenced this pull request May 29, 2021
@mcollina
Revert sent refactoring (#3108)
c566292 
* Revert "fix #3099 (#3100)"

This reverts commit a848b0f.

* Revert "fixup! Simplify reply sent monitoring (#3072) (#3079)"

This reverts commit 9bf6a33.

* Revert "Simplify reply sent monitoring (#3072)"

This reverts commit 212fdb7.
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@climba03003 climba03003 climba03003 approved these changes

@Eomm Eomm Awaiting requested review from Eomm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

reply handling
3 participants
@mcollina @sergejostir @climba03003