Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert sent refactoring #3108

Merged
merged 3 commits into from
May 29, 2021
Merged

Revert sent refactoring #3108

merged 3 commits into from
May 29, 2021

Conversation

mcollina
Copy link
Member

Fixes #3107

Checklist

@mcollina
Copy link
Member Author

Unfortunately #3107 was too breaking, and we have received several regression reports. In order to fix this properly, we need #2702, which is semver-major.

I'm going to revert the refactoring on main but not in next.

@mcollina mcollina merged commit c566292 into main May 29, 2021
@mcollina mcollina deleted the revert-sent-refactoring branch May 29, 2021 08:39
mcollina added a commit that referenced this pull request May 29, 2021
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strange promises behaviour in v3.16.x
1 participant