feat(routes): expose findRoute and param validator #5230

sf3ris · 2023-12-23T09:49:02Z

Description

Quick draft of implementation to solve #5215
In this PR I wanted to expose an abstraction to retrieve a route for doing further checks.
Furthermore, I was doubtful about creating a standalone plugin for a simple check like this but open for any discussion.

Checklist

run npm run test and npm run benchmark
tests and/or benchmarks are included
documentation is changed or added
commit message and code follows the Developer's Certification of Origin
and the Code of conduct

lib/route.js

test/findRoute.test.js

mcollina

We support different kinds of validators. I don't think we should tie with a specific one and having the validations built in. It's likely better to have them in a separate plugin.

sf3ris · 2023-12-26T10:43:47Z

@mcollina @metcoder95 Makes sense to me, just a bit doubtful about the scope of the plugin.
What do you think about just exposing the findRoute as you suggested and leaving the plugin creation\implementation to later discussions?

metcoder95 · 2023-12-26T11:02:43Z

SGTM 👍

metcoder95

Nice! LGTM, small nit

metcoder95 · 2023-12-26T17:57:39Z

fastify.js

@@ -285,6 +285,9 @@ function fastify (options) {
    hasRoute: function _route (options) {
      return router.hasRoute.call(this, { options })
    },
+    findRoute: function _route (options) {


Suggested change

findRoute: function _route (options) {

findRoute: function _findRoute (options) {

mcollina · 2023-12-26T18:52:04Z

types/instance.d.ts

+    RouteGeneric extends RouteGenericInterface = RouteGenericInterface,
+    ContextConfig = ContextConfigDefault,
+    SchemaCompiler extends FastifySchema = FastifySchema,
+  >(opts: Pick<RouteOptions<RawServer, RawRequest, RawReply, RouteGeneric, ContextConfig, SchemaCompiler, TypeProvider>, 'method' | 'url' | 'constraints'>): FindResult<FindMyWayVersion<RawServer>>;


Could you add a test for this type? We use tsd.

mcollina

lgtm

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [fastify](https://fastify.dev/) ([source](https://togithub.com/fastify/fastify)) | [`4.25.2` -> `4.26.0`](https://renovatebot.com/diffs/npm/fastify/4.25.2/4.26.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/fastify/4.26.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/fastify/4.26.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/fastify/4.25.2/4.26.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/fastify/4.25.2/4.26.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>fastify/fastify (fastify)</summary> ### [`v4.26.0`](https://togithub.com/fastify/fastify/releases/tag/v4.26.0) [Compare Source](https://togithub.com/fastify/fastify/compare/v4.25.2...v4.26.0) #### What's Changed - docs(ecosystem): add missing plugins to core list by [@Fdawgs](https://togithub.com/Fdawgs) in [fastify/fastify#5234 - ci: CITGM github workflow by [@Uzlopak](https://togithub.com/Uzlopak) in [fastify/fastify#5233 - chore: bump find-may-way to v8.0.0 by [@mcollina](https://togithub.com/mcollina) in [fastify/fastify#5236 - fix: setValidatorCompiler with addSchema by [@derammo](https://togithub.com/derammo) in [fastify/fastify#5188 - feat(routes): expose findRoute and param validator by [@sf3ris](https://togithub.com/sf3ris) in [fastify/fastify#5230 - feat: add use semicolon delimter config, default = true by [@dancastillo](https://togithub.com/dancastillo) in [fastify/fastify#5239 - chore: add autocannon and concurrently as dev dependencies by [@Uzlopak](https://togithub.com/Uzlopak) in [fastify/fastify#5240 - fix: return the correct serializer function when no content-type is defined by [@DouglasdeMoura](https://togithub.com/DouglasdeMoura) in [fastify/fastify#5229 - Sync next by [@Uzlopak](https://togithub.com/Uzlopak) in [fastify/fastify#5238 - docs: add open-collective by [@Eomm](https://togithub.com/Eomm) in [fastify/fastify#5216 - chore: Bump actions/upload-artifact from 3 to 4 by [@dependabot](https://togithub.com/dependabot) in [fastify/fastify#5249 - chore: Bump actions/labeler from 4 to 5 by [@dependabot](https://togithub.com/dependabot) in [fastify/fastify#5248 - docs(ecosystem): update fastify-rabbitmq // add fastify-hl7 to ecosystem.md by [@Bugs5382](https://togithub.com/Bugs5382) in [fastify/fastify#5245 - chore: update actions/labeler@5 by [@climba03003](https://togithub.com/climba03003) in [fastify/fastify#5254 - fix: restrict findRoute exposed property by [@climba03003](https://togithub.com/climba03003) in [fastify/fastify#5253 - fix(test): flaky on-listen hook test by [@Uzlopak](https://togithub.com/Uzlopak) in [fastify/fastify#5256 - fix: remove unused promise warning in setNotFoundHandler with preHandler by [@mcollina](https://togithub.com/mcollina) in [fastify/fastify#5258 - fix: Always call resource.emitDestroy() by [@mcollina](https://togithub.com/mcollina) in [fastify/fastify#5228 - docs: Add missing punctuation in Ecosystem by [@matthyk](https://togithub.com/matthyk) in [fastify/fastify#5261 - docs: remove word repetition on Decorators docs by [@rlawisch](https://togithub.com/rlawisch) in [fastify/fastify#5260 - chore(types): Remove unused type imports by [@codershiba](https://togithub.com/codershiba) in [fastify/fastify#5264 - chore(license): Update licensing year by [@codershiba](https://togithub.com/codershiba) in [fastify/fastify#5266 - chore(docs): Add clarification about `fastify.setErrorHandler()` by [@codershiba](https://togithub.com/codershiba) in [fastify/fastify#5265 - refactor: deprecate `Reply#getResponseTime()` in favour of `Reply#elapsedTime` by [@codershiba](https://togithub.com/codershiba) in [fastify/fastify#5263 - chore: remove `www.` from `fastify.dev` urls by [@Fdawgs](https://togithub.com/Fdawgs) in [fastify/fastify#5270 - feat: expose method for setGenReqId on FastifyInstance by [@dancastillo](https://togithub.com/dancastillo) in [fastify/fastify#5259 - fix: ensure `onListen` hooks are called when they should be by [@bienzaaron](https://togithub.com/bienzaaron) in [fastify/fastify#5273 - docs: re-word clarification about `setErrorHandler()` by [@codershiba](https://togithub.com/codershiba) in [fastify/fastify#5269 - docs(ecosystem): remove unsupported package by [@Fdawgs](https://togithub.com/Fdawgs) in [fastify/fastify#5278 - docs: Fix Pino docs link by [@BoscoDomingo](https://togithub.com/BoscoDomingo) in [fastify/fastify#5284 - chore: add github sponsor by [@Eomm](https://togithub.com/Eomm) in [fastify/fastify#5293 - docs(ecosystem): adds fastify-sqlite-typed to the community plugins list by [@yoav0gal](https://togithub.com/yoav0gal) in [fastify/fastify#5288 - docs: add ESM usage example in Getting Started by [@atilagulers](https://togithub.com/atilagulers) in [fastify/fastify#5294 - docs: repoint readers to shared `.github` files by [@Fdawgs](https://togithub.com/Fdawgs) in [fastify/fastify#5268 - feat: Web Stream API by [@climba03003](https://togithub.com/climba03003) in [fastify/fastify#5286 - chore: sync generated code by [@Eomm](https://togithub.com/Eomm) in [fastify/fastify#5295 #### New Contributors - [@derammo](https://togithub.com/derammo) made their first contribution in [fastify/fastify#5188 - [@DouglasdeMoura](https://togithub.com/DouglasdeMoura) made their first contribution in [fastify/fastify#5229 - [@rlawisch](https://togithub.com/rlawisch) made their first contribution in [fastify/fastify#5260 - [@codershiba](https://togithub.com/codershiba) made their first contribution in [fastify/fastify#5264 - [@BoscoDomingo](https://togithub.com/BoscoDomingo) made their first contribution in [fastify/fastify#5284 - [@yoav0gal](https://togithub.com/yoav0gal) made their first contribution in [fastify/fastify#5288 - [@atilagulers](https://togithub.com/atilagulers) made their first contribution in [fastify/fastify#5294 **Full Changelog**: fastify/fastify@v4.25.2...v4.26.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/tomacheese/telcheck).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [fastify](https://fastify.dev/) ([source](https://togithub.com/fastify/fastify)) | [`4.25.2` -> `4.26.2`](https://renovatebot.com/diffs/npm/fastify/4.25.2/4.26.2) | [![age](https://developer.mend.io/api/mc/badges/age/npm/fastify/4.26.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/fastify/4.26.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/fastify/4.25.2/4.26.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/fastify/4.25.2/4.26.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>fastify/fastify (fastify)</summary> ### [`v4.26.2`](https://togithub.com/fastify/fastify/releases/tag/v4.26.2) [Compare Source](https://togithub.com/fastify/fastify/compare/v4.26.1...v4.26.2) #### What's Changed - fix: typo in module exports by [@lirantal](https://togithub.com/lirantal) in [fastify/fastify#5316 - docs(ts): Fix links by [@rozzilla](https://togithub.com/rozzilla) in [fastify/fastify#5308 - fix: cb is not a function at fallbackErrorHandler by [@Uzlopak](https://togithub.com/Uzlopak) in [fastify/fastify#5317 - feat: add a Firebase Functions step by step guide by [@lirantal](https://togithub.com/lirantal) in [fastify/fastify#5318 - types: fix test failure by [@gurgunday](https://togithub.com/gurgunday) in [fastify/fastify#5330 - perf: use FifoMap to check contentType by [@gurgunday](https://togithub.com/gurgunday) in [fastify/fastify#5331 - docs(ecosystem): adds fastify-override to plugins list by [@matthyk](https://togithub.com/matthyk) in [fastify/fastify#5336 - types: Export preClose hook types by [@matthyk](https://togithub.com/matthyk) in [fastify/fastify#5335 - fix: database migration doc missing db connection code by [@nuhman](https://togithub.com/nuhman) in [fastify/fastify#5339 - chore: Bump pnpm/action-setup from 2 to 3 by [@dependabot](https://togithub.com/dependabot) in [fastify/fastify#5341 - chore: Bump xt0rted/markdownlint-problem-matcher from 2.0.0 to 3.0.0 by [@dependabot](https://togithub.com/dependabot) in [fastify/fastify#5342 #### New Contributors - [@nuhman](https://togithub.com/nuhman) made their first contribution in [fastify/fastify#5339 **Full Changelog**: fastify/fastify@v4.26.1...v4.26.2 ### [`v4.26.1`](https://togithub.com/fastify/fastify/releases/tag/v4.26.1) [Compare Source](https://togithub.com/fastify/fastify/compare/v4.26.0...v4.26.1) #### What's Changed - docs(ecosystem): adds fastify-hana to the community plugins list by [@yoav0gal](https://togithub.com/yoav0gal) in [fastify/fastify#5289 - docs: fix misattributed property parent in deprecation warning: request.elapsedTime by [@mscottnelson](https://togithub.com/mscottnelson) in [fastify/fastify#5299 - chore: Bump lycheeverse/lychee-action from 1.8.0 to 1.9.3 by [@dependabot](https://togithub.com/dependabot) in [fastify/fastify#5300 - chore: Bump actions/dependency-review-action from 3 to 4 by [@dependabot](https://togithub.com/dependabot) in [fastify/fastify#5301 - chore(.gitignore): add .tap/ dir by [@Fdawgs](https://togithub.com/Fdawgs) in [fastify/fastify#5303 - fix: amend error codes for latest avvio v8.3.0 by [@mcollina](https://togithub.com/mcollina) in [fastify/fastify#5309 - fix(types): Request route options url add undefined by [@rozzilla](https://togithub.com/rozzilla) in [fastify/fastify#5307 - chore: add docs for tracing warnings by [@jsumners](https://togithub.com/jsumners) in [fastify/fastify#5310 #### New Contributors - [@mscottnelson](https://togithub.com/mscottnelson) made their first contribution in [fastify/fastify#5299 **Full Changelog**: fastify/fastify@v4.26.0...v4.26.1 ### [`v4.26.0`](https://togithub.com/fastify/fastify/releases/tag/v4.26.0) [Compare Source](https://togithub.com/fastify/fastify/compare/v4.25.2...v4.26.0) #### What's Changed - docs(ecosystem): add missing plugins to core list by [@Fdawgs](https://togithub.com/Fdawgs) in [fastify/fastify#5234 - ci: CITGM github workflow by [@Uzlopak](https://togithub.com/Uzlopak) in [fastify/fastify#5233 - chore: bump find-may-way to v8.0.0 by [@mcollina](https://togithub.com/mcollina) in [fastify/fastify#5236 - fix: setValidatorCompiler with addSchema by [@derammo](https://togithub.com/derammo) in [fastify/fastify#5188 - feat(routes): expose findRoute and param validator by [@sf3ris](https://togithub.com/sf3ris) in [fastify/fastify#5230 - feat: add use semicolon delimter config, default = true by [@dancastillo](https://togithub.com/dancastillo) in [fastify/fastify#5239 - chore: add autocannon and concurrently as dev dependencies by [@Uzlopak](https://togithub.com/Uzlopak) in [fastify/fastify#5240 - fix: return the correct serializer function when no content-type is defined by [@DouglasdeMoura](https://togithub.com/DouglasdeMoura) in [fastify/fastify#5229 - Sync next by [@Uzlopak](https://togithub.com/Uzlopak) in [fastify/fastify#5238 - docs: add open-collective by [@Eomm](https://togithub.com/Eomm) in [fastify/fastify#5216 - chore: Bump actions/upload-artifact from 3 to 4 by [@dependabot](https://togithub.com/dependabot) in [fastify/fastify#5249 - chore: Bump actions/labeler from 4 to 5 by [@dependabot](https://togithub.com/dependabot) in [fastify/fastify#5248 - docs(ecosystem): update fastify-rabbitmq // add fastify-hl7 to ecosystem.md by [@Bugs5382](https://togithub.com/Bugs5382) in [fastify/fastify#5245 - chore: update actions/labeler@5 by [@climba03003](https://togithub.com/climba03003) in [fastify/fastify#5254 - fix: restrict findRoute exposed property by [@climba03003](https://togithub.com/climba03003) in [fastify/fastify#5253 - fix(test): flaky on-listen hook test by [@Uzlopak](https://togithub.com/Uzlopak) in [fastify/fastify#5256 - fix: remove unused promise warning in setNotFoundHandler with preHandler by [@mcollina](https://togithub.com/mcollina) in [fastify/fastify#5258 - fix: Always call resource.emitDestroy() by [@mcollina](https://togithub.com/mcollina) in [fastify/fastify#5228 - docs: Add missing punctuation in Ecosystem by [@matthyk](https://togithub.com/matthyk) in [fastify/fastify#5261 - docs: remove word repetition on Decorators docs by [@rlawisch](https://togithub.com/rlawisch) in [fastify/fastify#5260 - chore(types): Remove unused type imports by [@codershiba](https://togithub.com/codershiba) in [fastify/fastify#5264 - chore(license): Update licensing year by [@codershiba](https://togithub.com/codershiba) in [fastify/fastify#5266 - chore(docs): Add clarification about `fastify.setErrorHandler()` by [@codershiba](https://togithub.com/codershiba) in [fastify/fastify#5265 - refactor: deprecate `Reply#getResponseTime()` in favour of `Reply#elapsedTime` by [@codershiba](https://togithub.com/codershiba) in [fastify/fastify#5263 - chore: remove `www.` from `fastify.dev` urls by [@Fdawgs](https://togithub.com/Fdawgs) in [fastify/fastify#5270 - feat: expose method for setGenReqId on FastifyInstance by [@dancastillo](https://togithub.com/dancastillo) in [fastify/fastify#5259 - fix: ensure `onListen` hooks are called when they should be by [@bienzaaron](https://togithub.com/bienzaaron) in [fastify/fastify#5273 - docs: re-word clarification about `setErrorHandler()` by [@codershiba](https://togithub.com/codershiba) in [fastify/fastify#5269 - docs(ecosystem): remove unsupported package by [@Fdawgs](https://togithub.com/Fdawgs) in [fastify/fastify#5278 - docs: Fix Pino docs link by [@BoscoDomingo](https://togithub.com/BoscoDomingo) in [fastify/fastify#5284 - chore: add github sponsor by [@Eomm](https://togithub.com/Eomm) in [fastify/fastify#5293 - docs(ecosystem): adds fastify-sqlite-typed to the community plugins list by [@yoav0gal](https://togithub.com/yoav0gal) in [fastify/fastify#5288 - docs: add ESM usage example in Getting Started by [@atilagulers](https://togithub.com/atilagulers) in [fastify/fastify#5294 - docs: repoint readers to shared `.github` files by [@Fdawgs](https://togithub.com/Fdawgs) in [fastify/fastify#5268 - feat: Web Stream API by [@climba03003](https://togithub.com/climba03003) in [fastify/fastify#5286 - chore: sync generated code by [@Eomm](https://togithub.com/Eomm) in [fastify/fastify#5295 #### New Contributors - [@derammo](https://togithub.com/derammo) made their first contribution in [fastify/fastify#5188 - [@DouglasdeMoura](https://togithub.com/DouglasdeMoura) made their first contribution in [fastify/fastify#5229 - [@rlawisch](https://togithub.com/rlawisch) made their first contribution in [fastify/fastify#5260 - [@codershiba](https://togithub.com/codershiba) made their first contribution in [fastify/fastify#5264 - [@BoscoDomingo](https://togithub.com/BoscoDomingo) made their first contribution in [fastify/fastify#5284 - [@yoav0gal](https://togithub.com/yoav0gal) made their first contribution in [fastify/fastify#5288 - [@atilagulers](https://togithub.com/atilagulers) made their first contribution in [fastify/fastify#5294 **Full Changelog**: fastify/fastify@v4.25.2...v4.26.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/redwoodjs/redwood).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [fastify](https://fastify.dev/) ([source](https://togithub.com/fastify/fastify)) | [`4.25.2` -> `4.26.2`](https://renovatebot.com/diffs/npm/fastify/4.25.2/4.26.2) | [![age](https://developer.mend.io/api/mc/badges/age/npm/fastify/4.26.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/fastify/4.26.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/fastify/4.25.2/4.26.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/fastify/4.25.2/4.26.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- <details> <summary>fastify/fastify (fastify)</summary> [`v4.26.2`](https://togithub.com/fastify/fastify/releases/tag/v4.26.2) [Compare Source](https://togithub.com/fastify/fastify/compare/v4.26.1...v4.26.2) - fix: typo in module exports by [@lirantal](https://togithub.com/lirantal) in [fastify/fastify#5316 - docs(ts): Fix links by [@rozzilla](https://togithub.com/rozzilla) in [fastify/fastify#5308 - fix: cb is not a function at fallbackErrorHandler by [@Uzlopak](https://togithub.com/Uzlopak) in [fastify/fastify#5317 - feat: add a Firebase Functions step by step guide by [@lirantal](https://togithub.com/lirantal) in [fastify/fastify#5318 - types: fix test failure by [@gurgunday](https://togithub.com/gurgunday) in [fastify/fastify#5330 - perf: use FifoMap to check contentType by [@gurgunday](https://togithub.com/gurgunday) in [fastify/fastify#5331 - docs(ecosystem): adds fastify-override to plugins list by [@matthyk](https://togithub.com/matthyk) in [fastify/fastify#5336 - types: Export preClose hook types by [@matthyk](https://togithub.com/matthyk) in [fastify/fastify#5335 - fix: database migration doc missing db connection code by [@nuhman](https://togithub.com/nuhman) in [fastify/fastify#5339 - chore: Bump pnpm/action-setup from 2 to 3 by [@dependabot](https://togithub.com/dependabot) in [fastify/fastify#5341 - chore: Bump xt0rted/markdownlint-problem-matcher from 2.0.0 to 3.0.0 by [@dependabot](https://togithub.com/dependabot) in [fastify/fastify#5342 - [@nuhman](https://togithub.com/nuhman) made their first contribution in [fastify/fastify#5339 **Full Changelog**: fastify/fastify@v4.26.1...v4.26.2 [`v4.26.1`](https://togithub.com/fastify/fastify/releases/tag/v4.26.1) [Compare Source](https://togithub.com/fastify/fastify/compare/v4.26.0...v4.26.1) - docs(ecosystem): adds fastify-hana to the community plugins list by [@yoav0gal](https://togithub.com/yoav0gal) in [fastify/fastify#5289 - docs: fix misattributed property parent in deprecation warning: request.elapsedTime by [@mscottnelson](https://togithub.com/mscottnelson) in [fastify/fastify#5299 - chore: Bump lycheeverse/lychee-action from 1.8.0 to 1.9.3 by [@dependabot](https://togithub.com/dependabot) in [fastify/fastify#5300 - chore: Bump actions/dependency-review-action from 3 to 4 by [@dependabot](https://togithub.com/dependabot) in [fastify/fastify#5301 - chore(.gitignore): add .tap/ dir by [@Fdawgs](https://togithub.com/Fdawgs) in [fastify/fastify#5303 - fix: amend error codes for latest avvio v8.3.0 by [@mcollina](https://togithub.com/mcollina) in [fastify/fastify#5309 - fix(types): Request route options url add undefined by [@rozzilla](https://togithub.com/rozzilla) in [fastify/fastify#5307 - chore: add docs for tracing warnings by [@jsumners](https://togithub.com/jsumners) in [fastify/fastify#5310 - [@mscottnelson](https://togithub.com/mscottnelson) made their first contribution in [fastify/fastify#5299 **Full Changelog**: fastify/fastify@v4.26.0...v4.26.1 [`v4.26.0`](https://togithub.com/fastify/fastify/releases/tag/v4.26.0) [Compare Source](https://togithub.com/fastify/fastify/compare/v4.25.2...v4.26.0) - docs(ecosystem): add missing plugins to core list by [@Fdawgs](https://togithub.com/Fdawgs) in [fastify/fastify#5234 - ci: CITGM github workflow by [@Uzlopak](https://togithub.com/Uzlopak) in [fastify/fastify#5233 - chore: bump find-may-way to v8.0.0 by [@mcollina](https://togithub.com/mcollina) in [fastify/fastify#5236 - fix: setValidatorCompiler with addSchema by [@derammo](https://togithub.com/derammo) in [fastify/fastify#5188 - feat(routes): expose findRoute and param validator by [@sf3ris](https://togithub.com/sf3ris) in [fastify/fastify#5230 - feat: add use semicolon delimter config, default = true by [@dancastillo](https://togithub.com/dancastillo) in [fastify/fastify#5239 - chore: add autocannon and concurrently as dev dependencies by [@Uzlopak](https://togithub.com/Uzlopak) in [fastify/fastify#5240 - fix: return the correct serializer function when no content-type is defined by [@DouglasdeMoura](https://togithub.com/DouglasdeMoura) in [fastify/fastify#5229 - Sync next by [@Uzlopak](https://togithub.com/Uzlopak) in [fastify/fastify#5238 - docs: add open-collective by [@Eomm](https://togithub.com/Eomm) in [fastify/fastify#5216 - chore: Bump actions/upload-artifact from 3 to 4 by [@dependabot](https://togithub.com/dependabot) in [fastify/fastify#5249 - chore: Bump actions/labeler from 4 to 5 by [@dependabot](https://togithub.com/dependabot) in [fastify/fastify#5248 - docs(ecosystem): update fastify-rabbitmq // add fastify-hl7 to ecosystem.md by [@Bugs5382](https://togithub.com/Bugs5382) in [fastify/fastify#5245 - chore: update actions/labeler@5 by [@climba03003](https://togithub.com/climba03003) in [fastify/fastify#5254 - fix: restrict findRoute exposed property by [@climba03003](https://togithub.com/climba03003) in [fastify/fastify#5253 - fix(test): flaky on-listen hook test by [@Uzlopak](https://togithub.com/Uzlopak) in [fastify/fastify#5256 - fix: remove unused promise warning in setNotFoundHandler with preHandler by [@mcollina](https://togithub.com/mcollina) in [fastify/fastify#5258 - fix: Always call resource.emitDestroy() by [@mcollina](https://togithub.com/mcollina) in [fastify/fastify#5228 - docs: Add missing punctuation in Ecosystem by [@matthyk](https://togithub.com/matthyk) in [fastify/fastify#5261 - docs: remove word repetition on Decorators docs by [@rlawisch](https://togithub.com/rlawisch) in [fastify/fastify#5260 - chore(types): Remove unused type imports by [@codershiba](https://togithub.com/codershiba) in [fastify/fastify#5264 - chore(license): Update licensing year by [@codershiba](https://togithub.com/codershiba) in [fastify/fastify#5266 - chore(docs): Add clarification about `fastify.setErrorHandler()` by [@codershiba](https://togithub.com/codershiba) in [fastify/fastify#5265 - refactor: deprecate `Reply#getResponseTime()` in favour of `Reply#elapsedTime` by [@codershiba](https://togithub.com/codershiba) in [fastify/fastify#5263 - chore: remove `www.` from `fastify.dev` urls by [@Fdawgs](https://togithub.com/Fdawgs) in [fastify/fastify#5270 - feat: expose method for setGenReqId on FastifyInstance by [@dancastillo](https://togithub.com/dancastillo) in [fastify/fastify#5259 - fix: ensure `onListen` hooks are called when they should be by [@bienzaaron](https://togithub.com/bienzaaron) in [fastify/fastify#5273 - docs: re-word clarification about `setErrorHandler()` by [@codershiba](https://togithub.com/codershiba) in [fastify/fastify#5269 - docs(ecosystem): remove unsupported package by [@Fdawgs](https://togithub.com/Fdawgs) in [fastify/fastify#5278 - docs: Fix Pino docs link by [@BoscoDomingo](https://togithub.com/BoscoDomingo) in [fastify/fastify#5284 - chore: add github sponsor by [@Eomm](https://togithub.com/Eomm) in [fastify/fastify#5293 - docs(ecosystem): adds fastify-sqlite-typed to the community plugins list by [@yoav0gal](https://togithub.com/yoav0gal) in [fastify/fastify#5288 - docs: add ESM usage example in Getting Started by [@atilagulers](https://togithub.com/atilagulers) in [fastify/fastify#5294 - docs: repoint readers to shared `.github` files by [@Fdawgs](https://togithub.com/Fdawgs) in [fastify/fastify#5268 - feat: Web Stream API by [@climba03003](https://togithub.com/climba03003) in [fastify/fastify#5286 - chore: sync generated code by [@Eomm](https://togithub.com/Eomm) in [fastify/fastify#5295 - [@derammo](https://togithub.com/derammo) made their first contribution in [fastify/fastify#5188 - [@DouglasdeMoura](https://togithub.com/DouglasdeMoura) made their first contribution in [fastify/fastify#5229 - [@rlawisch](https://togithub.com/rlawisch) made their first contribution in [fastify/fastify#5260 - [@codershiba](https://togithub.com/codershiba) made their first contribution in [fastify/fastify#5264 - [@BoscoDomingo](https://togithub.com/BoscoDomingo) made their first contribution in [fastify/fastify#5284 - [@yoav0gal](https://togithub.com/yoav0gal) made their first contribution in [fastify/fastify#5288 - [@atilagulers](https://togithub.com/atilagulers) made their first contribution in [fastify/fastify#5294 **Full Changelog**: fastify/fastify@v4.25.2...v4.26.0 </details> --- 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/redwoodjs/redwood).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

sf3ris mentioned this pull request Dec 23, 2023

Option to align route params with schema at startup #5215

Open

2 tasks

metcoder95 reviewed Dec 24, 2023

View reviewed changes

lib/route.js Outdated Show resolved Hide resolved

test/findRoute.test.js Outdated Show resolved Hide resolved

mcollina requested changes Dec 25, 2023

View reviewed changes

sf3ris force-pushed the sf3ris/feature/issues-5215-abstract-fmw-routes branch from 53d9385 to b3ad236 Compare December 26, 2023 11:32

sf3ris requested review from metcoder95 and mcollina December 26, 2023 11:34

metcoder95 reviewed Dec 26, 2023

View reviewed changes

mcollina reviewed Dec 26, 2023

View reviewed changes

sf3ris added 4 commits December 27, 2023 14:02

feat(routes): expose findRoute and param validator

b1bf120

fix: remove route validation

0512122

chore: update documentation

19ec132

fix: add type checking tests

a06ad26

sf3ris force-pushed the sf3ris/feature/issues-5215-abstract-fmw-routes branch from 1216f81 to a06ad26 Compare December 27, 2023 13:02

sf3ris requested review from mcollina and metcoder95 December 27, 2023 13:03

mcollina approved these changes Dec 27, 2023

View reviewed changes

metcoder95 approved these changes Dec 27, 2023

View reviewed changes

mcollina merged commit 7264c88 into fastify:main Dec 27, 2023
28 checks passed

sf3ris deleted the sf3ris/feature/issues-5215-abstract-fmw-routes branch December 30, 2023 10:17

climba03003 mentioned this pull request Jan 4, 2024

fix: restrict findRoute exposed property #5253

Merged

4 tasks

renovate bot mentioned this pull request Feb 21, 2024

chore(deps): update all non-major dependencies jellydn/stepci-demo#88

Open

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(routes): expose findRoute and param validator #5230

feat(routes): expose findRoute and param validator #5230

sf3ris commented Dec 23, 2023 •

edited

mcollina left a comment

sf3ris commented Dec 26, 2023

metcoder95 commented Dec 26, 2023

metcoder95 left a comment

metcoder95 Dec 26, 2023

mcollina Dec 26, 2023

mcollina left a comment

	findRoute: function _route (options) {
	findRoute: function _findRoute (options) {

feat(routes): expose findRoute and param validator #5230

feat(routes): expose findRoute and param validator #5230

Conversation

sf3ris commented Dec 23, 2023 • edited

Description

Checklist

mcollina left a comment

Choose a reason for hiding this comment

sf3ris commented Dec 26, 2023

metcoder95 commented Dec 26, 2023

metcoder95 left a comment

Choose a reason for hiding this comment

metcoder95 Dec 26, 2023

Choose a reason for hiding this comment

mcollina Dec 26, 2023

Choose a reason for hiding this comment

mcollina left a comment

Choose a reason for hiding this comment

sf3ris commented Dec 23, 2023 •

edited