Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure onListen hooks are called when they should be #5273

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

bienzaaron
Copy link
Contributor

@bienzaaron bienzaaron commented Jan 17, 2024

This PR fixes an issue where the onListen application hooks don't run in some cases when they should:

  1. When there is an onListen hook registered in a child encapsulation context, but the parent context does not have one
  2. When there are multiple encapsulation contexts that are peers (i.e. at the same level / both children of the same parent), only the first will run

See example code:

const Fastify = require('./fastify.js')

const fastify = Fastify({ logger: true })

fastify.addHook('onListen', (done) => {
  console.log('i am called')
  done()
})

fastify.register((instance, opts, done) => {
  instance.addHook('onListen', (hookDone) => {
    console.log('i am also called')
    hookDone()
  })

  // create an encapsulation, and then create another immediately inside it
  instance.register((instance2, opts, done2) => {
    instance2.register((instance3, opts, done3) => {
      instance3.addHook('onListen', (hookDone) => {
        console.log('i am not called, because my parent does not have an onListen hook')
        hookDone()
      })
      done3()
    })
    done2()
  })
  done()
})

// since there is another context at this level (i.e. peer context), the hook inside this context won't run.
fastify.register((instance, opts, done) => {
  instance.addHook('onListen', (hookDone) => {
    console.log('i am not called because I am a peer context')
    hookDone()
  })
  done()
})

fastify.listen({ port: 3000 })

With the current version of fastify, this produces the following log output:

{"level":30,"time":1705470523577,"pid":99149,"hostname":"AJs-MacBook-Pro.local","msg":"Server listening at http://[::1]:3000"}
{"level":30,"time":1705470523578,"pid":99149,"hostname":"AJs-MacBook-Pro.local","msg":"Server listening at http://127.0.0.1:3000"}
i am called
i am also called

I believe the appropriate output would be:

{"level":30,"time":1705470550633,"pid":99225,"hostname":"AJs-MacBook-Pro.local","msg":"Server listening at http://[::1]:3000"}
{"level":30,"time":1705470550634,"pid":99225,"hostname":"AJs-MacBook-Pro.local","msg":"Server listening at http://127.0.0.1:3000"}
i am called
i am also called
i am not called, because my parent does not have an onListen hook
i am not called because I am a peer context

Checklist

Copy link
Member

@climba03003 climba03003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be easier to always share the same onListen array?
Then we don't need to lookup the children tree and search for the event listener.

this binding would fail, so it is not an option.

Copy link
Member

@metcoder95 metcoder95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice catch 👍

The change should be ok, when creating the tree it seems we navigated it vertically but missed horizontally, that's the reason why the while does seem to do the trick

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 79042e6 into fastify:main Jan 17, 2024
renovate bot added a commit to tomacheese/telcheck that referenced this pull request Feb 1, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [fastify](https://fastify.dev/)
([source](https://togithub.com/fastify/fastify)) | [`4.25.2` ->
`4.26.0`](https://renovatebot.com/diffs/npm/fastify/4.25.2/4.26.0) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/fastify/4.26.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/fastify/4.26.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/fastify/4.25.2/4.26.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/fastify/4.25.2/4.26.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>fastify/fastify (fastify)</summary>

###
[`v4.26.0`](https://togithub.com/fastify/fastify/releases/tag/v4.26.0)

[Compare
Source](https://togithub.com/fastify/fastify/compare/v4.25.2...v4.26.0)

#### What's Changed

- docs(ecosystem): add missing plugins to core list by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[fastify/fastify#5234
- ci: CITGM github workflow by
[@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[fastify/fastify#5233
- chore: bump find-may-way to v8.0.0 by
[@&#8203;mcollina](https://togithub.com/mcollina) in
[fastify/fastify#5236
- fix: setValidatorCompiler with addSchema by
[@&#8203;derammo](https://togithub.com/derammo) in
[fastify/fastify#5188
- feat(routes): expose findRoute and param validator by
[@&#8203;sf3ris](https://togithub.com/sf3ris) in
[fastify/fastify#5230
- feat: add use semicolon delimter config, default = true by
[@&#8203;dancastillo](https://togithub.com/dancastillo) in
[fastify/fastify#5239
- chore: add autocannon and concurrently as dev dependencies by
[@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[fastify/fastify#5240
- fix: return the correct serializer function when no content-type is
defined by [@&#8203;DouglasdeMoura](https://togithub.com/DouglasdeMoura)
in
[fastify/fastify#5229
- Sync next by [@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[fastify/fastify#5238
- docs: add open-collective by [@&#8203;Eomm](https://togithub.com/Eomm)
in
[fastify/fastify#5216
- chore: Bump actions/upload-artifact from 3 to 4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[fastify/fastify#5249
- chore: Bump actions/labeler from 4 to 5 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[fastify/fastify#5248
- docs(ecosystem): update fastify-rabbitmq // add fastify-hl7 to
ecosystem.md by [@&#8203;Bugs5382](https://togithub.com/Bugs5382) in
[fastify/fastify#5245
- chore: update actions/labeler@5 by
[@&#8203;climba03003](https://togithub.com/climba03003) in
[fastify/fastify#5254
- fix: restrict findRoute exposed property by
[@&#8203;climba03003](https://togithub.com/climba03003) in
[fastify/fastify#5253
- fix(test): flaky on-listen hook test by
[@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[fastify/fastify#5256
- fix: remove unused promise warning in setNotFoundHandler with
preHandler by [@&#8203;mcollina](https://togithub.com/mcollina) in
[fastify/fastify#5258
- fix: Always call resource.emitDestroy() by
[@&#8203;mcollina](https://togithub.com/mcollina) in
[fastify/fastify#5228
- docs: Add missing punctuation in Ecosystem by
[@&#8203;matthyk](https://togithub.com/matthyk) in
[fastify/fastify#5261
- docs: remove word repetition on Decorators docs by
[@&#8203;rlawisch](https://togithub.com/rlawisch) in
[fastify/fastify#5260
- chore(types): Remove unused type imports by
[@&#8203;codershiba](https://togithub.com/codershiba) in
[fastify/fastify#5264
- chore(license): Update licensing year by
[@&#8203;codershiba](https://togithub.com/codershiba) in
[fastify/fastify#5266
- chore(docs): Add clarification about `fastify.setErrorHandler()` by
[@&#8203;codershiba](https://togithub.com/codershiba) in
[fastify/fastify#5265
- refactor: deprecate `Reply#getResponseTime()` in favour of
`Reply#elapsedTime` by
[@&#8203;codershiba](https://togithub.com/codershiba) in
[fastify/fastify#5263
- chore: remove `www.` from `fastify.dev` urls by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[fastify/fastify#5270
- feat: expose method for setGenReqId on FastifyInstance by
[@&#8203;dancastillo](https://togithub.com/dancastillo) in
[fastify/fastify#5259
- fix: ensure `onListen` hooks are called when they should be by
[@&#8203;bienzaaron](https://togithub.com/bienzaaron) in
[fastify/fastify#5273
- docs: re-word clarification about `setErrorHandler()` by
[@&#8203;codershiba](https://togithub.com/codershiba) in
[fastify/fastify#5269
- docs(ecosystem): remove unsupported package by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[fastify/fastify#5278
- docs: Fix Pino docs link by
[@&#8203;BoscoDomingo](https://togithub.com/BoscoDomingo) in
[fastify/fastify#5284
- chore: add github sponsor by [@&#8203;Eomm](https://togithub.com/Eomm)
in
[fastify/fastify#5293
- docs(ecosystem): adds fastify-sqlite-typed to the community plugins
list by [@&#8203;yoav0gal](https://togithub.com/yoav0gal) in
[fastify/fastify#5288
- docs: add ESM usage example in Getting Started by
[@&#8203;atilagulers](https://togithub.com/atilagulers) in
[fastify/fastify#5294
- docs: repoint readers to shared `.github` files by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[fastify/fastify#5268
- feat: Web Stream API by
[@&#8203;climba03003](https://togithub.com/climba03003) in
[fastify/fastify#5286
- chore: sync generated code by
[@&#8203;Eomm](https://togithub.com/Eomm) in
[fastify/fastify#5295

#### New Contributors

- [@&#8203;derammo](https://togithub.com/derammo) made their first
contribution in
[fastify/fastify#5188
- [@&#8203;DouglasdeMoura](https://togithub.com/DouglasdeMoura) made
their first contribution in
[fastify/fastify#5229
- [@&#8203;rlawisch](https://togithub.com/rlawisch) made their first
contribution in
[fastify/fastify#5260
- [@&#8203;codershiba](https://togithub.com/codershiba) made their first
contribution in
[fastify/fastify#5264
- [@&#8203;BoscoDomingo](https://togithub.com/BoscoDomingo) made their
first contribution in
[fastify/fastify#5284
- [@&#8203;yoav0gal](https://togithub.com/yoav0gal) made their first
contribution in
[fastify/fastify#5288
- [@&#8203;atilagulers](https://togithub.com/atilagulers) made their
first contribution in
[fastify/fastify#5294

**Full Changelog**:
fastify/fastify@v4.25.2...v4.26.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/tomacheese/telcheck).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjE1My4yIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot added a commit to redwoodjs/redwood that referenced this pull request Mar 7, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [fastify](https://fastify.dev/)
([source](https://togithub.com/fastify/fastify)) | [`4.25.2` ->
`4.26.2`](https://renovatebot.com/diffs/npm/fastify/4.25.2/4.26.2) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/fastify/4.26.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/fastify/4.26.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/fastify/4.25.2/4.26.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/fastify/4.25.2/4.26.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>fastify/fastify (fastify)</summary>

###
[`v4.26.2`](https://togithub.com/fastify/fastify/releases/tag/v4.26.2)

[Compare
Source](https://togithub.com/fastify/fastify/compare/v4.26.1...v4.26.2)

#### What's Changed

- fix: typo in module exports by
[@&#8203;lirantal](https://togithub.com/lirantal) in
[fastify/fastify#5316
- docs(ts): Fix links by
[@&#8203;rozzilla](https://togithub.com/rozzilla) in
[fastify/fastify#5308
- fix: cb is not a function at fallbackErrorHandler by
[@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[fastify/fastify#5317
- feat: add a Firebase Functions step by step guide by
[@&#8203;lirantal](https://togithub.com/lirantal) in
[fastify/fastify#5318
- types: fix test failure by
[@&#8203;gurgunday](https://togithub.com/gurgunday) in
[fastify/fastify#5330
- perf: use FifoMap to check contentType by
[@&#8203;gurgunday](https://togithub.com/gurgunday) in
[fastify/fastify#5331
- docs(ecosystem): adds fastify-override to plugins list by
[@&#8203;matthyk](https://togithub.com/matthyk) in
[fastify/fastify#5336
- types: Export preClose hook types by
[@&#8203;matthyk](https://togithub.com/matthyk) in
[fastify/fastify#5335
- fix: database migration doc missing db connection code by
[@&#8203;nuhman](https://togithub.com/nuhman) in
[fastify/fastify#5339
- chore: Bump pnpm/action-setup from 2 to 3 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[fastify/fastify#5341
- chore: Bump xt0rted/markdownlint-problem-matcher from 2.0.0 to 3.0.0
by [@&#8203;dependabot](https://togithub.com/dependabot) in
[fastify/fastify#5342

#### New Contributors

- [@&#8203;nuhman](https://togithub.com/nuhman) made their first
contribution in
[fastify/fastify#5339

**Full Changelog**:
fastify/fastify@v4.26.1...v4.26.2

###
[`v4.26.1`](https://togithub.com/fastify/fastify/releases/tag/v4.26.1)

[Compare
Source](https://togithub.com/fastify/fastify/compare/v4.26.0...v4.26.1)

#### What's Changed

- docs(ecosystem): adds fastify-hana to the community plugins list by
[@&#8203;yoav0gal](https://togithub.com/yoav0gal) in
[fastify/fastify#5289
- docs: fix misattributed property parent in deprecation warning:
request.elapsedTime by
[@&#8203;mscottnelson](https://togithub.com/mscottnelson) in
[fastify/fastify#5299
- chore: Bump lycheeverse/lychee-action from 1.8.0 to 1.9.3 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[fastify/fastify#5300
- chore: Bump actions/dependency-review-action from 3 to 4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[fastify/fastify#5301
- chore(.gitignore): add .tap/ dir by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[fastify/fastify#5303
- fix: amend error codes for latest avvio v8.3.0 by
[@&#8203;mcollina](https://togithub.com/mcollina) in
[fastify/fastify#5309
- fix(types): Request route options url add undefined by
[@&#8203;rozzilla](https://togithub.com/rozzilla) in
[fastify/fastify#5307
- chore: add docs for tracing warnings by
[@&#8203;jsumners](https://togithub.com/jsumners) in
[fastify/fastify#5310

#### New Contributors

- [@&#8203;mscottnelson](https://togithub.com/mscottnelson) made their
first contribution in
[fastify/fastify#5299

**Full Changelog**:
fastify/fastify@v4.26.0...v4.26.1

###
[`v4.26.0`](https://togithub.com/fastify/fastify/releases/tag/v4.26.0)

[Compare
Source](https://togithub.com/fastify/fastify/compare/v4.25.2...v4.26.0)

#### What's Changed

- docs(ecosystem): add missing plugins to core list by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[fastify/fastify#5234
- ci: CITGM github workflow by
[@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[fastify/fastify#5233
- chore: bump find-may-way to v8.0.0 by
[@&#8203;mcollina](https://togithub.com/mcollina) in
[fastify/fastify#5236
- fix: setValidatorCompiler with addSchema by
[@&#8203;derammo](https://togithub.com/derammo) in
[fastify/fastify#5188
- feat(routes): expose findRoute and param validator by
[@&#8203;sf3ris](https://togithub.com/sf3ris) in
[fastify/fastify#5230
- feat: add use semicolon delimter config, default = true by
[@&#8203;dancastillo](https://togithub.com/dancastillo) in
[fastify/fastify#5239
- chore: add autocannon and concurrently as dev dependencies by
[@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[fastify/fastify#5240
- fix: return the correct serializer function when no content-type is
defined by [@&#8203;DouglasdeMoura](https://togithub.com/DouglasdeMoura)
in
[fastify/fastify#5229
- Sync next by [@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[fastify/fastify#5238
- docs: add open-collective by [@&#8203;Eomm](https://togithub.com/Eomm)
in
[fastify/fastify#5216
- chore: Bump actions/upload-artifact from 3 to 4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[fastify/fastify#5249
- chore: Bump actions/labeler from 4 to 5 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[fastify/fastify#5248
- docs(ecosystem): update fastify-rabbitmq // add fastify-hl7 to
ecosystem.md by [@&#8203;Bugs5382](https://togithub.com/Bugs5382) in
[fastify/fastify#5245
- chore: update actions/labeler@5 by
[@&#8203;climba03003](https://togithub.com/climba03003) in
[fastify/fastify#5254
- fix: restrict findRoute exposed property by
[@&#8203;climba03003](https://togithub.com/climba03003) in
[fastify/fastify#5253
- fix(test): flaky on-listen hook test by
[@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[fastify/fastify#5256
- fix: remove unused promise warning in setNotFoundHandler with
preHandler by [@&#8203;mcollina](https://togithub.com/mcollina) in
[fastify/fastify#5258
- fix: Always call resource.emitDestroy() by
[@&#8203;mcollina](https://togithub.com/mcollina) in
[fastify/fastify#5228
- docs: Add missing punctuation in Ecosystem by
[@&#8203;matthyk](https://togithub.com/matthyk) in
[fastify/fastify#5261
- docs: remove word repetition on Decorators docs by
[@&#8203;rlawisch](https://togithub.com/rlawisch) in
[fastify/fastify#5260
- chore(types): Remove unused type imports by
[@&#8203;codershiba](https://togithub.com/codershiba) in
[fastify/fastify#5264
- chore(license): Update licensing year by
[@&#8203;codershiba](https://togithub.com/codershiba) in
[fastify/fastify#5266
- chore(docs): Add clarification about `fastify.setErrorHandler()` by
[@&#8203;codershiba](https://togithub.com/codershiba) in
[fastify/fastify#5265
- refactor: deprecate `Reply#getResponseTime()` in favour of
`Reply#elapsedTime` by
[@&#8203;codershiba](https://togithub.com/codershiba) in
[fastify/fastify#5263
- chore: remove `www.` from `fastify.dev` urls by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[fastify/fastify#5270
- feat: expose method for setGenReqId on FastifyInstance by
[@&#8203;dancastillo](https://togithub.com/dancastillo) in
[fastify/fastify#5259
- fix: ensure `onListen` hooks are called when they should be by
[@&#8203;bienzaaron](https://togithub.com/bienzaaron) in
[fastify/fastify#5273
- docs: re-word clarification about `setErrorHandler()` by
[@&#8203;codershiba](https://togithub.com/codershiba) in
[fastify/fastify#5269
- docs(ecosystem): remove unsupported package by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[fastify/fastify#5278
- docs: Fix Pino docs link by
[@&#8203;BoscoDomingo](https://togithub.com/BoscoDomingo) in
[fastify/fastify#5284
- chore: add github sponsor by [@&#8203;Eomm](https://togithub.com/Eomm)
in
[fastify/fastify#5293
- docs(ecosystem): adds fastify-sqlite-typed to the community plugins
list by [@&#8203;yoav0gal](https://togithub.com/yoav0gal) in
[fastify/fastify#5288
- docs: add ESM usage example in Getting Started by
[@&#8203;atilagulers](https://togithub.com/atilagulers) in
[fastify/fastify#5294
- docs: repoint readers to shared `.github` files by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[fastify/fastify#5268
- feat: Web Stream API by
[@&#8203;climba03003](https://togithub.com/climba03003) in
[fastify/fastify#5286
- chore: sync generated code by
[@&#8203;Eomm](https://togithub.com/Eomm) in
[fastify/fastify#5295

#### New Contributors

- [@&#8203;derammo](https://togithub.com/derammo) made their first
contribution in
[fastify/fastify#5188
- [@&#8203;DouglasdeMoura](https://togithub.com/DouglasdeMoura) made
their first contribution in
[fastify/fastify#5229
- [@&#8203;rlawisch](https://togithub.com/rlawisch) made their first
contribution in
[fastify/fastify#5260
- [@&#8203;codershiba](https://togithub.com/codershiba) made their first
contribution in
[fastify/fastify#5264
- [@&#8203;BoscoDomingo](https://togithub.com/BoscoDomingo) made their
first contribution in
[fastify/fastify#5284
- [@&#8203;yoav0gal](https://togithub.com/yoav0gal) made their first
contribution in
[fastify/fastify#5288
- [@&#8203;atilagulers](https://togithub.com/atilagulers) made their
first contribution in
[fastify/fastify#5294

**Full Changelog**:
fastify/fastify@v4.25.2...v4.26.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/redwoodjs/redwood).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMjAuMiIsInVwZGF0ZWRJblZlciI6IjM3LjIyNy4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
jtoar pushed a commit to redwoodjs/redwood that referenced this pull request Mar 7, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [fastify](https://fastify.dev/)
([source](https://togithub.com/fastify/fastify)) | [`4.25.2` ->
`4.26.2`](https://renovatebot.com/diffs/npm/fastify/4.25.2/4.26.2) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/fastify/4.26.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/fastify/4.26.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/fastify/4.25.2/4.26.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/fastify/4.25.2/4.26.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

<details>
<summary>fastify/fastify (fastify)</summary>

[`v4.26.2`](https://togithub.com/fastify/fastify/releases/tag/v4.26.2)

[Compare
Source](https://togithub.com/fastify/fastify/compare/v4.26.1...v4.26.2)

- fix: typo in module exports by
[@&#8203;lirantal](https://togithub.com/lirantal) in
[fastify/fastify#5316
- docs(ts): Fix links by
[@&#8203;rozzilla](https://togithub.com/rozzilla) in
[fastify/fastify#5308
- fix: cb is not a function at fallbackErrorHandler by
[@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[fastify/fastify#5317
- feat: add a Firebase Functions step by step guide by
[@&#8203;lirantal](https://togithub.com/lirantal) in
[fastify/fastify#5318
- types: fix test failure by
[@&#8203;gurgunday](https://togithub.com/gurgunday) in
[fastify/fastify#5330
- perf: use FifoMap to check contentType by
[@&#8203;gurgunday](https://togithub.com/gurgunday) in
[fastify/fastify#5331
- docs(ecosystem): adds fastify-override to plugins list by
[@&#8203;matthyk](https://togithub.com/matthyk) in
[fastify/fastify#5336
- types: Export preClose hook types by
[@&#8203;matthyk](https://togithub.com/matthyk) in
[fastify/fastify#5335
- fix: database migration doc missing db connection code by
[@&#8203;nuhman](https://togithub.com/nuhman) in
[fastify/fastify#5339
- chore: Bump pnpm/action-setup from 2 to 3 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[fastify/fastify#5341
- chore: Bump xt0rted/markdownlint-problem-matcher from 2.0.0 to 3.0.0
by [@&#8203;dependabot](https://togithub.com/dependabot) in
[fastify/fastify#5342

- [@&#8203;nuhman](https://togithub.com/nuhman) made their first
contribution in
[fastify/fastify#5339

**Full Changelog**:
fastify/fastify@v4.26.1...v4.26.2

[`v4.26.1`](https://togithub.com/fastify/fastify/releases/tag/v4.26.1)

[Compare
Source](https://togithub.com/fastify/fastify/compare/v4.26.0...v4.26.1)

- docs(ecosystem): adds fastify-hana to the community plugins list by
[@&#8203;yoav0gal](https://togithub.com/yoav0gal) in
[fastify/fastify#5289
- docs: fix misattributed property parent in deprecation warning:
request.elapsedTime by
[@&#8203;mscottnelson](https://togithub.com/mscottnelson) in
[fastify/fastify#5299
- chore: Bump lycheeverse/lychee-action from 1.8.0 to 1.9.3 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[fastify/fastify#5300
- chore: Bump actions/dependency-review-action from 3 to 4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[fastify/fastify#5301
- chore(.gitignore): add .tap/ dir by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[fastify/fastify#5303
- fix: amend error codes for latest avvio v8.3.0 by
[@&#8203;mcollina](https://togithub.com/mcollina) in
[fastify/fastify#5309
- fix(types): Request route options url add undefined by
[@&#8203;rozzilla](https://togithub.com/rozzilla) in
[fastify/fastify#5307
- chore: add docs for tracing warnings by
[@&#8203;jsumners](https://togithub.com/jsumners) in
[fastify/fastify#5310

- [@&#8203;mscottnelson](https://togithub.com/mscottnelson) made their
first contribution in
[fastify/fastify#5299

**Full Changelog**:
fastify/fastify@v4.26.0...v4.26.1

[`v4.26.0`](https://togithub.com/fastify/fastify/releases/tag/v4.26.0)

[Compare
Source](https://togithub.com/fastify/fastify/compare/v4.25.2...v4.26.0)

- docs(ecosystem): add missing plugins to core list by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[fastify/fastify#5234
- ci: CITGM github workflow by
[@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[fastify/fastify#5233
- chore: bump find-may-way to v8.0.0 by
[@&#8203;mcollina](https://togithub.com/mcollina) in
[fastify/fastify#5236
- fix: setValidatorCompiler with addSchema by
[@&#8203;derammo](https://togithub.com/derammo) in
[fastify/fastify#5188
- feat(routes): expose findRoute and param validator by
[@&#8203;sf3ris](https://togithub.com/sf3ris) in
[fastify/fastify#5230
- feat: add use semicolon delimter config, default = true by
[@&#8203;dancastillo](https://togithub.com/dancastillo) in
[fastify/fastify#5239
- chore: add autocannon and concurrently as dev dependencies by
[@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[fastify/fastify#5240
- fix: return the correct serializer function when no content-type is
defined by [@&#8203;DouglasdeMoura](https://togithub.com/DouglasdeMoura)
in
[fastify/fastify#5229
- Sync next by [@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[fastify/fastify#5238
- docs: add open-collective by [@&#8203;Eomm](https://togithub.com/Eomm)
in
[fastify/fastify#5216
- chore: Bump actions/upload-artifact from 3 to 4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[fastify/fastify#5249
- chore: Bump actions/labeler from 4 to 5 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[fastify/fastify#5248
- docs(ecosystem): update fastify-rabbitmq // add fastify-hl7 to
ecosystem.md by [@&#8203;Bugs5382](https://togithub.com/Bugs5382) in
[fastify/fastify#5245
- chore: update actions/labeler@5 by
[@&#8203;climba03003](https://togithub.com/climba03003) in
[fastify/fastify#5254
- fix: restrict findRoute exposed property by
[@&#8203;climba03003](https://togithub.com/climba03003) in
[fastify/fastify#5253
- fix(test): flaky on-listen hook test by
[@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[fastify/fastify#5256
- fix: remove unused promise warning in setNotFoundHandler with
preHandler by [@&#8203;mcollina](https://togithub.com/mcollina) in
[fastify/fastify#5258
- fix: Always call resource.emitDestroy() by
[@&#8203;mcollina](https://togithub.com/mcollina) in
[fastify/fastify#5228
- docs: Add missing punctuation in Ecosystem by
[@&#8203;matthyk](https://togithub.com/matthyk) in
[fastify/fastify#5261
- docs: remove word repetition on Decorators docs by
[@&#8203;rlawisch](https://togithub.com/rlawisch) in
[fastify/fastify#5260
- chore(types): Remove unused type imports by
[@&#8203;codershiba](https://togithub.com/codershiba) in
[fastify/fastify#5264
- chore(license): Update licensing year by
[@&#8203;codershiba](https://togithub.com/codershiba) in
[fastify/fastify#5266
- chore(docs): Add clarification about `fastify.setErrorHandler()` by
[@&#8203;codershiba](https://togithub.com/codershiba) in
[fastify/fastify#5265
- refactor: deprecate `Reply#getResponseTime()` in favour of
`Reply#elapsedTime` by
[@&#8203;codershiba](https://togithub.com/codershiba) in
[fastify/fastify#5263
- chore: remove `www.` from `fastify.dev` urls by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[fastify/fastify#5270
- feat: expose method for setGenReqId on FastifyInstance by
[@&#8203;dancastillo](https://togithub.com/dancastillo) in
[fastify/fastify#5259
- fix: ensure `onListen` hooks are called when they should be by
[@&#8203;bienzaaron](https://togithub.com/bienzaaron) in
[fastify/fastify#5273
- docs: re-word clarification about `setErrorHandler()` by
[@&#8203;codershiba](https://togithub.com/codershiba) in
[fastify/fastify#5269
- docs(ecosystem): remove unsupported package by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[fastify/fastify#5278
- docs: Fix Pino docs link by
[@&#8203;BoscoDomingo](https://togithub.com/BoscoDomingo) in
[fastify/fastify#5284
- chore: add github sponsor by [@&#8203;Eomm](https://togithub.com/Eomm)
in
[fastify/fastify#5293
- docs(ecosystem): adds fastify-sqlite-typed to the community plugins
list by [@&#8203;yoav0gal](https://togithub.com/yoav0gal) in
[fastify/fastify#5288
- docs: add ESM usage example in Getting Started by
[@&#8203;atilagulers](https://togithub.com/atilagulers) in
[fastify/fastify#5294
- docs: repoint readers to shared `.github` files by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[fastify/fastify#5268
- feat: Web Stream API by
[@&#8203;climba03003](https://togithub.com/climba03003) in
[fastify/fastify#5286
- chore: sync generated code by
[@&#8203;Eomm](https://togithub.com/Eomm) in
[fastify/fastify#5295

- [@&#8203;derammo](https://togithub.com/derammo) made their first
contribution in
[fastify/fastify#5188
- [@&#8203;DouglasdeMoura](https://togithub.com/DouglasdeMoura) made
their first contribution in
[fastify/fastify#5229
- [@&#8203;rlawisch](https://togithub.com/rlawisch) made their first
contribution in
[fastify/fastify#5260
- [@&#8203;codershiba](https://togithub.com/codershiba) made their first
contribution in
[fastify/fastify#5264
- [@&#8203;BoscoDomingo](https://togithub.com/BoscoDomingo) made their
first contribution in
[fastify/fastify#5284
- [@&#8203;yoav0gal](https://togithub.com/yoav0gal) made their first
contribution in
[fastify/fastify#5288
- [@&#8203;atilagulers](https://togithub.com/atilagulers) made their
first contribution in
[fastify/fastify#5294

**Full Changelog**:
fastify/fastify@v4.25.2...v4.26.0

</details>

---

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/redwoodjs/redwood).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMjAuMiIsInVwZGF0ZWRJblZlciI6IjM3LjIyNy4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants