This repository has been archived by the owner. It is now read-only.
Permalink
Browse files

Add overcommit

Summary:

* Resolve #1001
* Run tests before pushing up changes
  • Loading branch information...
Ashraf-Ali-aa committed Jun 20, 2018
1 parent 15fbf59 commit d73ff56ed0fc186f07345ca1c8439f656db44f37
Showing with 55 additions and 5 deletions.
  1. +41 −0 .overcommit.yml
  2. +6 −5 Gemfile
  3. +8 −0 Gemfile.lock
View
@@ -0,0 +1,41 @@
# Use this file to configure the Overcommit hooks you wish to use. This will
# extend the default configuration defined in:
# https://github.com/brigade/overcommit/blob/master/config/default.yml
#
# At the topmost level of this YAML file is a key representing type of hook
# being run (e.g. pre-commit, commit-msg, etc.). Within each type you can
# customize each hook, such as whether to only run it on certain files (via
# `include`), whether to only display output if it fails (via `quiet`), etc.
#
# For a complete list of hooks, see:
# https://github.com/brigade/overcommit/tree/master/lib/overcommit/hook
#
# For a complete list of options that you can use to customize hooks, see:
# https://github.com/brigade/overcommit#configuration
#
# Uncomment the following lines to make the configuration take effect.
PreCommit:
RuboCop:
enabled: true
on_warn: fail # Treat all warnings as failures
TsLint:
enabled: true
on_warn: fail
PrePush:
RSpec:
enabled: true
on_warn: fail
#
# TrailingWhitespace:
# enabled: true
# exclude:
# - '**/db/structure.sql' # Ignore trailing whitespace in generated files
#
#PostCheckout:
# ALL: # Special hook name that customizes all hooks of this type
# quiet: true # Change all post-checkout hooks to only display output on failure
#
# IndexTags:
# enabled: true # Generate a tags file with `ctags` each time HEAD changes
View
11 Gemfile
@@ -5,11 +5,11 @@ source("https://rubygems.org")
# gem "gem_name", ">= 1.3.4", "< 2.0.0" # comment on why we need this dependency
#
# Note:
# - Always add a comment on why this dependency is needed
# - Always use `>=` and `<` to define a version range:
# - This way we can require a minimum version, including a hotfix while also
# - defining a maximum version (major = breaking)
# - If we used `~>` we can't define a patch release without being too strict with our locking
# - Always add a comment on why this dependency is needed
# - Always use `>=` and `<` to define a version range:
# - This way we can require a minimum version, including a hotfix while also
# - defining a maximum version (major = breaking)
# - If we used `~>` we can't define a patch release without being too strict with our locking
#
# Sinatra
@@ -78,6 +78,7 @@ gem "git", git: "https://github.com/fastlane/ruby-git", require: false # Interac
group :test, :development do
gem "coveralls"
gem "grpc-tools"
gem "overcommit"
gem "pry"
gem "pry-byebug"
gem "rack-test", require: "rack/test"
View
@@ -95,6 +95,8 @@ GEM
backports (3.11.3)
bcrypt (3.1.12)
byebug (10.0.2)
childprocess (0.9.0)
ffi (~> 1.0, >= 1.0.11)
claide (1.0.2)
coderay (1.1.2)
colored (1.2)
@@ -142,6 +144,7 @@ GEM
faye-websocket (0.10.7)
eventmachine (>= 0.12.0)
websocket-driver (>= 0.5.1)
ffi (1.9.25)
fugit (1.1.1)
et-orbi (~> 1.1, >= 1.1.1)
raabro (~> 1.1)
@@ -177,6 +180,7 @@ GEM
i18n (1.0.1)
concurrent-ruby (~> 1.0)
ice_nine (0.11.2)
iniparse (1.4.4)
json (2.1.0)
jwt (2.1.0)
little-plugger (1.1.4)
@@ -202,6 +206,9 @@ GEM
octokit (4.9.0)
sawyer (~> 0.8.0, >= 0.5.3)
os (0.9.6)
overcommit (0.45.0)
childprocess (~> 0.6, >= 0.6.3)
iniparse (~> 1.4)
parallel (1.12.1)
parser (2.4.0.2)
ast (~> 2.3)
@@ -367,6 +374,7 @@ DEPENDENCIES
jwt (>= 2.1.0, < 3.0.0)
micromachine (>= 3.0.0, < 4.0.0)
octokit (>= 4.8.0, < 5.0.0)
overcommit
pry
pry-byebug
rack-test

0 comments on commit d73ff56

Please sign in to comment.