Skip to content
This repository has been archived by the owner on Sep 6, 2022. It is now read-only.

Revert "Use JWTAuth Middleware to check correct authentication with t… #885

Closed
wants to merge 1 commit into from

Conversation

nakhbari
Copy link
Contributor

Revert "Use JWTAuth Middleware to check correct authentication with the backend. (#872)"
This reverts commit 1a25394.

The middleware auth is being applied to all routes, blocking most requests.

  • I have tested this change locally and tried to launch the server as well as access a project, and with that at least one build
  • If there is an existing issue, make sure to add Fixes ... as part of the PR body to refernece the issue you're solving

@nakhbari nakhbari requested a review from a team May 16, 2018 23:54
@nakhbari nakhbari requested a review from a team as a code owner May 16, 2018 23:54
Copy link
Contributor

@minuscorp minuscorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's ready to merge, although I don't know why is this blocking, it should block every viewmodel request except from logging in (as expected)

Copy link
Contributor

@minuscorp minuscorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will block this until #888 is reviewed and merged. Better that than reverting the whole auth.

@taquitos
Copy link
Collaborator

@minuscorp / @nakhbari now that the referenced PR is merged (#888) do we still need to revert or does that fix the problem?

@nakhbari
Copy link
Contributor Author

@snatchev is working on robustification, let's close this for now

@nakhbari nakhbari closed this May 17, 2018
@KrauseFx KrauseFx deleted the revert-jwt branch May 21, 2018 16:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants