Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos across the codebase #1231

Merged
merged 22 commits into from
Jan 18, 2024
Merged

Fix typos across the codebase #1231

merged 22 commits into from
Jan 18, 2024

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Jan 15, 2024

Fixes misspellings identified by the check-spelling action.

The misspellings have been reported at https://github.com/jsoref/fastlane-docs/actions/runs/7523387426/attempts/1#summary-20476689368

The action will report that the changes in this PR would make it happy: https://github.com/jsoref/fastlane-docs/actions/runs/7523387549/attempts/1#summary-20476689646

Copy link
Member

@rogerluan rogerluan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some files to be reverted plus some minor improvements. The other fixes LGTM! 🎉

Thanks for this @jsoref! 🙌

docs/plugins/available-plugins.md Outdated Show resolved Hide resolved
docs/generated/actions.md Outdated Show resolved Hide resolved
docs/best-practices/continuous-integration/bamboo.md Outdated Show resolved Hide resolved
.rubocop.yml Outdated Show resolved Hide resolved
Copy link
Member

@rogerluan rogerluan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@rogerluan rogerluan changed the title Spelling Fix typos across the codebase Jan 18, 2024
@rogerluan
Copy link
Member

There's an issue with CI currently, I still have to look into this 😬 I'm gonna go ahead and merge it in anyway

@rogerluan
Copy link
Member

Actually I decided to fix the issue in a separate PR, and it got merged. Could you rebase/merge master into this branch @jsoref ? 🙇

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@rogerluan rogerluan merged commit c5491f4 into fastlane:master Jan 18, 2024
2 checks passed
@rogerluan
Copy link
Member

Thanks @jsoref !! ❤️

@jsoref jsoref deleted the spelling branch January 18, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants