[old]Add QuizUp to fastlane examples #26
Conversation
|
Sup? :) |
| ### [QuizUp](https://www.quizup.com) | ||
| [](https://www.quizup.com) | ||
|
|
||
| :rocket: **Advanced - Multiple Environments** |
There was a problem hiding this comment.
The rocket emoji is already taken by fastlane 😉
There was a problem hiding this comment.
Oh noes, will change :)
|
So sorry I somehow lost this tab - thank you so much for this pull request, this looks great already. I added some comments before it's ready to be merged 👍 |
|
Thanks for taking the time to review @KrauseFx ,I think I've addressed all of your comments :) |
|
|
||
| s3 = Aws::S3::Resource.new | ||
| file_path = options[:ipa] | ||
| obj = s3.bucket(ENV['SECRET-PROJECT-BUCKET-NAME']).object(File.basename(file_path)) |
There was a problem hiding this comment.
This should be an option defined in the available_options
There was a problem hiding this comment.
@KrauseFx sorry for taking so long to fix this small thing, I forgot I had this PR open :(
There was a problem hiding this comment.
Looks great to me, just some minor comments added here and there... Thanks for sharing @alliannas
| submit_ipa | ||
| end | ||
|
|
||
| desc "Resubmits the the build" |
There was a problem hiding this comment.
Minor typo here
- desc "Resubmits the the build"
+ desc "Resubmits the build"| desc "- Installs cocoapods" | ||
| desc "- Runs tests" | ||
| desc "- Cleanup" | ||
| lane :test do |
There was a problem hiding this comment.
Missing cocoapods here attending to the description?
| - Project setup | ||
| - Version Bump & Git Actions | ||
| - Slack Notifications | ||
| - Custom action for internal tranlsation tools |
There was a problem hiding this comment.
Minor typo:
- Custom action for internal tranlsation tools
+ Custom action for internal translation tools
alliannas
changed the title
Let me just first say, thank you so much for creating this amazing tool. It has saved us countless hours when doing submissions to Apple!
So to give you a little context on why our setup is like its here, is a little explanation on how we do things.
QuizUp fastlane setup
For Development
We use a feature branch model and when a feature is merged in (or a part of it, if its large we split it up into multiple PRs) our CI automatically builds the
hourly_buildlane and sends to our internal hockey app.Each night, if there were any changes done to master we upload a build to our hockey beta group.
This is the
daily_buildlane.Translations
QuizUp is currently supported in 7 languages, and its not possible for us to have a very detailed as many of we the features we do are behind an AB tests.
Our global champions create in advance a list of funny changelogs for each locale and our CI tool selects 1 of them for each release to the App Store.
To accomplish this we use 2 custom actions as explained below.
Release flow
We have two main branches, release and master. All work is done against the
masterbranch and all app store releases are done on thereleasebranch.While waiting for review we still continue to merge new and potentially untested code into
master.To test the App Store build we use Testflight and if a critical bug is found in that build we fix that on the release branch do call the
resubmit, which only updates the build number.Custom actions
We have a lot of custom actions for things we have to do, like selecting the changelogs, updating translations with our internal tool
uhuraand a few minors ones.All feedback is greatly appreciated and we look forward to hear from you and hope we can provide some value with open sourcing our fastfile.
QuizUp iOS Team.