Add QuizUp to fastlane examples #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Annas Helgason <alliannas@gmail.com>
Signed-off-by: Alexander Annas Helgason <alliannas@gmail.com>
Signed-off-by: Alexander Annas Helgason <alliannas@gmail.com>
Signed-off-by: Alexander Annas Helgason <alliannas@gmail.com>
KrauseFx
reviewed
Jan 17, 2017
| end | ||
| end | ||
|
|
||
| unless localesWithMissingChangeLog.empty? |
There was a problem hiding this comment.
Variables shouldn't be camel case, but use _ 👍
There was a problem hiding this comment.
Fixed in b950e34 :)
|
Hey @alliannas, awesome, thanks for preparing this. The PR looks great, however could you update it to use |
|
Yeah will do. |
KrauseFx
approved these changes
Jan 19, 2017
|
Cool, thank you so much for contributing this, I'm sure this will help a lot of people 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let me just first say, thank you so much for creating this amazing tool. It has saved us countless hours when doing submissions to Apple!
So to give you a little context on why our setup is like its here, is a little explanation on how we do things.
QuizUp fastlane setup
For Development
We use a feature branch model and when a feature is merged in (or a part of it, if its large we split it up into multiple PRs) our CI automatically builds the
hourly_buildlane and sends to our internal hockey app.Each night, if there were any changes done to master we upload a build to our hockey beta group.
This is the
daily_buildlane.Translations
QuizUp is currently supported in 7 languages, and its not possible for us to have a very detailed as many of we the features we do are behind an AB tests.
Our global champions create in advance a list of funny changelogs for each locale and our CI tool selects 1 of them for each release to the App Store.
To accomplish this we use 2 custom actions as explained below.
Release flow
We have two main branches, release and master. All work is done against the
masterbranch and all app store releases are done on thereleasebranch.While waiting for review we still continue to merge new and potentially untested code into
master.To test the App Store build we use Testflight and if a critical bug is found in that build we fix that on the release branch do call the
resubmit, which only updates the build number.Custom actions
We have a lot of custom actions for things we have to do, like selecting the changelogs, updating translations with our internal tool
uhuraand a few minors ones.All feedback is greatly appreciated and we look forward to hear from you and hope we can provide some value with open sourcing our fastfile.
QuizUp iOS Team.