Don't allow spaces in IPA file name being uploaded to ITC (#12321)

* Don't allow spaces in IPA file name being uploaded to ITC

* Space stuff

* Space stuff

fastlane_core/lib/fastlane_core/ipa_upload_package_builder.rb

@@ -36,7 +36,8 @@ def generate(app_id: nil, ipa_path: nil, package_path: nil, platform: nil)
     end
 
     def unique_ipa_path(ipa_path)
-      "#{File.basename(ipa_path, '.ipa')}_#{Digest::SHA256.file(ipa_path).hexdigest}.ipa"
+      basename = File.basename(ipa_path, '.ipa').gsub(' ', '_')
+      "#{basename}_#{Digest::SHA256.file(ipa_path).hexdigest}.ipa"
     end
 
     private

fastlane_core/spec/ipa_upload_package_builder_spec.rb

@@ -5,6 +5,10 @@
     let(:uploader) { FastlaneCore::IpaUploadPackageBuilder.new }
     let(:unique_path) { uploader.unique_ipa_path(path) }
 
+    let(:ipa_with_spaces) { 'iOS App With Spaces' }
+    let(:path_with_spaces) { File.expand_path("../fixtures/ipas/#{ipa_with_spaces}.ipa", __FILE__) }
+    let(:unique_path_with_spaces) { uploader.unique_ipa_path(path_with_spaces) }
+
     def special_chars?(string)
       string =~ /^[A-Za-z0-9_\.]+$/ ? false : true
     end
@@ -43,6 +47,10 @@ def special_chars?(string)
           expect(unique_path).not_to(start_with(okay_char))
         end
       end
+
+      it 'does not contain any spaces' do
+        expect(unique_path_with_spaces.include?(' ')).to eq(false)
+      end
     end
   end
 end