Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't allow spaces in IPA file name being uploaded to ITC #12321

Merged
merged 3 commits into from Apr 17, 2018
Merged

Don't allow spaces in IPA file name being uploaded to ITC #12321

merged 3 commits into from Apr 17, 2018

Conversation

joshdholtz
Copy link
Member

Fixes #12294

KrauseFx
KrauseFx approved these changes Apr 17, 2018
View reviewed changes
Copy link
Member

@KrauseFx KrauseFx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweeet

@joshdholtz joshdholtz merged commit 61a16a2 into master Apr 17, 2018
@joshdholtz joshdholtz deleted the joshdholtz-no-spaces-in-uploaded-ipa-filename branch April 17, 2018 01:08
@joshdholtz joshdholtz mentioned this pull request Apr 17, 2018
Merged
joshdholtz pushed a commit that referenced this pull request Apr 17, 2018
Revert "Don't allow spaces in IPA file name being uploaded to ITC (#1…
61a92af 
…2321)"

This reverts commit 61a16a2.
joshdholtz pushed a commit that referenced this pull request Apr 17, 2018
Revert "[match] Correct how match handles enterprise adhoc" (#12328)
93f1c4b 
* Revert "Version bump to 2.92.0 (#12323)"

This reverts commit df64e77.

* Revert "Don't allow spaces in IPA file name being uploaded to ITC (#12321)"

This reverts commit 61a16a2.

* Revert "[match] Correct how match handles enterprise adhoc (#12281)"

This reverts commit d0c3b3f.
@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.92.0 🚀

@fastlane fastlane locked and limited conversation to collaborators Jun 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@KrauseFx KrauseFx KrauseFx approved these changes

Assignees
No one assigned
Labels
cla: yes status: released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@joshdholtz @fastlane-bot @KrauseFx @googlebot