Frameit produces desaturated images

[florentalexdr]

New Issue Checklist

• [V ] Updated fastlane to the latest version
• [V] I read the Contribution Guidelines
• [V ] I read docs.fastlane.tools
• [V ] I searched for existing GitHub issues

Issue Description

I'm running fastlane frameit in my project which used to work great but now generates desaturated black and white screenshots.

Command executed

fastlane frameit

Complete output when running fastlane, including the stack trace and command used

 bundle exec fastlane frameit                                                                              09:58:46
[✔] 🚀
[09:58:55]: Using device frames version 'latest'
[✔] Framing screenshot './screenshots/en_US/iPhone 11 Pro Max-theme_creation.png'
[09:59:09]: Added frame: '/Users/florent/Documents/git/scenekitdice/screenshots/en_US/iPhone 11 Pro Max-theme_creation_framed.png'
[✔] Framing screenshot './screenshots/en_US/iPhone 11 Pro Max-rolling2.png'
[09:59:22]: Added frame: '/Users/florent/Documents/git/scenekitdice/screenshots/en_US/iPhone 11 Pro Max-rolling2_framed.png'
[✔] Framing screenshot './screenshots/en_US/iPad Pro (12.9-inch)-theme_creation.png'
[09:59:43]: Added frame: '/Users/florent/Documents/git/scenekitdice/screenshots/en_US/iPad Pro (12.9-inch)-theme_creation_framed.png'
[✔] Framing screenshot './screenshots/en_US/iPhone 11 Pro Max-settings.png'
[09:59:57]: Added frame: '/Users/florent/Documents/git/scenekitdice/screenshots/en_US/iPhone 11 Pro Max-settings_framed.png'
[✔] Framing screenshot './screenshots/en_US/iPhone 11 Pro Max-selection1.png'
[10:00:10]: Added frame: '/Users/florent/Documents/git/scenekitdice/screenshots/en_US/iPhone 11 Pro Max-selection1_framed.png'
[✔] Framing screenshot './screenshots/en_US/iPad Pro (12.9-inch)-selection2.png'
[10:00:31]: Added frame: '/Users/florent/Documents/git/scenekitdice/screenshots/en_US/iPad Pro (12.9-inch)-selection2_framed.png'
[✔] Framing screenshot './screenshots/en_US/iPhone 11 Pro Max-selection2.png'
[10:00:44]: Added frame: '/Users/florent/Documents/git/scenekitdice/screenshots/en_US/iPhone 11 Pro Max-selection2_framed.png'
[✔] Framing screenshot './screenshots/en_US/iPad Pro (12.9-inch)-selection1.png'
[10:01:05]: Added frame: '/Users/florent/Documents/git/scenekitdice/screenshots/en_US/iPad Pro (12.9-inch)-selection1_framed.png'
[✔] Framing screenshot './screenshots/en_US/iPad Pro (12.9-inch)-rolling.png'
[10:01:25]: Added frame: '/Users/florent/Documents/git/scenekitdice/screenshots/en_US/iPad Pro (12.9-inch)-rolling_framed.png'
[✔] Framing screenshot './screenshots/en_US/iPad Pro (12.9-inch)-rolling2.png'
[10:01:45]: Added frame: '/Users/florent/Documents/git/scenekitdice/screenshots/en_US/iPad Pro (12.9-inch)-rolling2_framed.png'
[✔] Framing screenshot './screenshots/en_US/iPhone 11 Pro Max-rolling.png'
[10:01:58]: Added frame: '/Users/florent/Documents/git/scenekitdice/screenshots/en_US/iPhone 11 Pro Max-rolling_framed.png'
[✔] Framing screenshot './screenshots/en_US/iPad Pro (12.9-inch)-result2.png'
[10:02:18]: Added frame: '/Users/florent/Documents/git/scenekitdice/screenshots/en_US/iPad Pro (12.9-inch)-result2_framed.png'
[✔] Framing screenshot './screenshots/en_US/iPad Pro (12.9-inch)-settings.png'
[10:02:40]: Added frame: '/Users/florent/Documents/git/scenekitdice/screenshots/en_US/iPad Pro (12.9-inch)-settings_framed.png'
[✔] Framing screenshot './screenshots/en_US/iPad Pro (12.9-inch)-result1.png'
[10:03:00]: Added frame: '/Users/florent/Documents/git/scenekitdice/screenshots/en_US/iPad Pro (12.9-inch)-result1_framed.png'
[✔] Framing screenshot './screenshots/en_US/iPhone 11 Pro Max-result2.png'
[10:03:14]: Added frame: '/Users/florent/Documents/git/scenekitdice/screenshots/en_US/iPhone 11 Pro Max-result2_framed.png'
[✔] Framing screenshot './screenshots/en_US/iPhone 11 Pro Max-result1.png'
[10:03:26]: Added frame: '/Users/florent/Documents/git/scenekitdice/screenshots/en_US/iPhone 11 Pro Max-result1_framed.png'
[✔] Framing screenshot './screenshots/fr_FR/iPhone 11 Pro Max-theme_creation.png'
[10:03:40]: Added frame: '/Users/florent/Documents/git/scenekitdice/screenshots/fr_FR/iPhone 11 Pro Max-theme_creation_framed.png'
[✔] Framing screenshot './screenshots/fr_FR/iPhone 11 Pro Max-rolling2.png'
[10:03:52]: Added frame: '/Users/florent/Documents/git/scenekitdice/screenshots/fr_FR/iPhone 11 Pro Max-rolling2_framed.png'
[✔] Framing screenshot './screenshots/fr_FR/iPad Pro (12.9-inch)-theme_creation.png'
[10:04:14]: Added frame: '/Users/florent/Documents/git/scenekitdice/screenshots/fr_FR/iPad Pro (12.9-inch)-theme_creation_framed.png'
[✔] Framing screenshot './screenshots/fr_FR/iPhone 11 Pro Max-settings.png'
[10:04:27]: Added frame: '/Users/florent/Documents/git/scenekitdice/screenshots/fr_FR/iPhone 11 Pro Max-settings_framed.png'
[✔] Framing screenshot './screenshots/fr_FR/iPhone 11 Pro Max-selection1.png'
[10:04:40]: Added frame: '/Users/florent/Documents/git/scenekitdice/screenshots/fr_FR/iPhone 11 Pro Max-selection1_framed.png'
[✔] Framing screenshot './screenshots/fr_FR/iPad Pro (12.9-inch)-selection2.png'
[10:05:00]: Added frame: '/Users/florent/Documents/git/scenekitdice/screenshots/fr_FR/iPad Pro (12.9-inch)-selection2_framed.png'
[✔] Framing screenshot './screenshots/fr_FR/iPhone 11 Pro Max-selection2.png'
[10:05:12]: Added frame: '/Users/florent/Documents/git/scenekitdice/screenshots/fr_FR/iPhone 11 Pro Max-selection2_framed.png'
[✔] Framing screenshot './screenshots/fr_FR/iPad Pro (12.9-inch)-selection1.png'
[10:05:32]: Added frame: '/Users/florent/Documents/git/scenekitdice/screenshots/fr_FR/iPad Pro (12.9-inch)-selection1_framed.png'
[✔] Framing screenshot './screenshots/fr_FR/iPad Pro (12.9-inch)-rolling.png'
[10:05:51]: Added frame: '/Users/florent/Documents/git/scenekitdice/screenshots/fr_FR/iPad Pro (12.9-inch)-rolling_framed.png'
[✔] Framing screenshot './screenshots/fr_FR/iPad Pro (12.9-inch)-rolling2.png'
[10:06:10]: Added frame: '/Users/florent/Documents/git/scenekitdice/screenshots/fr_FR/iPad Pro (12.9-inch)-rolling2_framed.png'
[✔] Framing screenshot './screenshots/fr_FR/iPhone 11 Pro Max-rolling.png'
[10:06:22]: Added frame: '/Users/florent/Documents/git/scenekitdice/screenshots/fr_FR/iPhone 11 Pro Max-rolling_framed.png'
[✔] Framing screenshot './screenshots/fr_FR/iPad Pro (12.9-inch)-result2.png'
[10:06:41]: Added frame: '/Users/florent/Documents/git/scenekitdice/screenshots/fr_FR/iPad Pro (12.9-inch)-result2_framed.png'
[✔] Framing screenshot './screenshots/fr_FR/iPad Pro (12.9-inch)-settings.png'
[10:07:00]: Added frame: '/Users/florent/Documents/git/scenekitdice/screenshots/fr_FR/iPad Pro (12.9-inch)-settings_framed.png'
[✔] Framing screenshot './screenshots/fr_FR/iPad Pro (12.9-inch)-result1.png'
[10:07:19]: Added frame: '/Users/florent/Documents/git/scenekitdice/screenshots/fr_FR/iPad Pro (12.9-inch)-result1_framed.png'
[✔] Framing screenshot './screenshots/fr_FR/iPhone 11 Pro Max-result2.png'
[10:07:31]: Added frame: '/Users/florent/Documents/git/scenekitdice/screenshots/fr_FR/iPhone 11 Pro Max-result2_framed.png'
[✔] Framing screenshot './screenshots/fr_FR/iPhone 11 Pro Max-result1.png'
[10:07:44]: Added frame: '/Users/florent/Documents/git/scenekitdice/screenshots/fr_FR/iPhone 11 Pro Max-result1_framed.png' 

Environment

 
✅ fastlane environment ✅
Stack



Key
Value




OS
10.15.1


Ruby
2.6.5


Bundler?
true


Git
git version 2.21.0 (Apple Git-122)


Installation Source
~/.gem/ruby/2.6.5/bin/fastlane


Host
Mac OS X 10.15.1 (19B88)


Ruby Lib Dir
~/.rubies/ruby-2.6.5/lib


OpenSSL Version
OpenSSL 1.0.2t  10 Sep 2019


Is contained
false


Is homebrew
false


Is installed via Fabric.app
false


Xcode Path
/Applications/Xcode11.1.app/Contents/Developer/


Xcode Version
11.1



System Locale



Variable
Value





LANG
fr_FR.UTF-8
✅


LC_ALL




LANGUAGE





fastlane files:
No Fastfile found
No Appfile found
fastlane gems



Gem
Version
Update-Status




fastlane
2.134.0
✅ Up-To-Date



Loaded fastlane plugins:
No plugins Loaded
Loaded gems



Gem
Version




did_you_mean
1.3.1


bundler
1.17.2


etc
1.0.1


forwardable
1.2.0


CFPropertyList
3.0.1


concurrent-ruby
1.1.5


i18n
0.9.5


minitest
5.13.0


thread_safe
0.3.6


tzinfo
1.2.5


activesupport
4.2.11.1


public_suffix
2.0.5


addressable
2.7.0


httpclient
2.8.3


json
2.2.0


algoliasearch
1.27.1


atomos
0.1.3


babosa
1.0.3


claide
1.0.3


fuzzy_match
2.0.4


nap
1.1.0


cocoapods-core
1.8.4


cocoapods-deintegrate
1.0.4


cocoapods-downloader
1.2.2


cocoapods-plugins
1.0.0


cocoapods-search
1.0.0


cocoapods-stats
1.1.0


netrc
0.11.0


cocoapods-trunk
1.4.1


cocoapods-try
1.1.0


colored2
3.1.2


escape
0.0.4


fourflusher
2.3.1


gh_inspector
1.1.3


molinillo
0.6.6


ruby-macho
1.4.0


nanaimo
0.2.6


xcodeproj
1.13.0


cocoapods
1.8.4


colored
1.2


highline
1.7.10


commander-fastlane
4.4.6


declarative
0.0.10


declarative-option
0.1.0


digest-crc
0.4.1


unf_ext
0.0.7.6


unf
0.1.4


domain_name
0.5.20190701


dotenv
2.7.5


emoji_regex
1.0.1


excon
0.68.0


multipart-post
2.0.0


faraday
0.17.0


http-cookie
1.0.3


faraday-cookie_jar
0.0.6


faraday_middleware
0.13.1


fastimage
2.1.7


jwt
2.1.0


memoist
0.16.1


multi_json
1.14.1


os
1.0.1


signet
0.12.0


googleauth
0.6.7


mime-types-data
3.2019.1009


mime-types
3.3


uber
0.1.0


representable
3.0.4


retriable
3.1.2


google-api-client
0.23.9


google-cloud-env
1.3.0


google-cloud-core
1.4.1


google-cloud-storage
1.16.0


mini_magick
4.9.5


multi_xml
0.6.0


plist
3.5.0


rubyzip
1.3.0


security
0.1.3


naturally
2.2.0


simctl
1.6.6


slack-notifier
2.3.2


terminal-notifier
2.0.0


unicode-display_width
1.6.0


terminal-table
1.8.0


tty-screen
0.7.0


tty-cursor
0.7.0


tty-spinner
0.9.1


word_wrap
1.0.0


rouge
2.0.7


xcpretty
0.3.0


xcpretty-travis-formatter
1.0.0




generated on: 2019-11-11

[florentalexdr]

[janpio]

Ugh, that is an interesting one.
Can you reproduce this on a second computer?
Any idea what you changed or what got changed?

[florentalexdr]

I tried with the same fastfile and source images on an other mac and it worked fine. The main difference is Catalina on the machine where the bug appears.

…

________________________________ From: Jan Piotrowski <notifications@github.com> Sent: Saturday, November 16, 2019 11:14 PM To: fastlane/fastlane Cc: Florent Alexandre; Author Subject: Re: [fastlane/fastlane] Frameit produces desaturated images (#15619) Ugh, that is an interesting one. Can you reproduce this on a second computer? Any idea what you changed? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#15619?email_source=notifications&email_token=AAPVGIIXSNE3PCGU67RH7MLQUBWE3A5CNFSM4JLS3JX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEH3XZY#issuecomment-554679271>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAPVGINDFOLZKZ3HLOZLVE3QUBWE3ANCNFSM4JLS3JXQ>.

[janpio]

Oh no.

Can you maybe get the fastlane env output of that working computer and post it? Maybe some other dependency version is different and could be the cause of this.

[davekim]

👋 I also ran into this issue and I found something that worked for my use case but I wasn't sure if the implementation is the most elegant. My PR is linked as a talking point :)

[fastlane-bot]

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.

Please make sure to update to the latest fastlane version and check if that solves the issue. Let us know if that works for you by adding a comment 👍

Friendly reminder: contributions are always welcome! Check out CONTRIBUTING.md for more information on how to help with fastlane and feel free to tackle this issue yourself 💪

[fastlane-bot]

This issue will be auto-closed because there hasn't been any activity for a few months. Feel free to open a new one if you still experience this problem 👍