-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swift fastlane does not run on Apple Silicon #18502
Comments
I think you have to run the command through |
Yeah, that's possible, but in my test I also tried running the same task (and some larger tasks) with just plain Ruby fastlane and it run natively without any problem. In the error log there is issue somewhere in SockerServer, so there is probably some issue with threads or something like that. |
This really seem to be very promising TBH
|
There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Friendly reminder: contributions are always welcome! Check out CONTRIBUTING.md for more information on how to help with This issue will be auto-closed if there is no reply within 1 month. |
I checked it already with 2.182.0 and still same issue. |
It seems to me like an issue with the project and the new architecture, but I cannot do much about it because I have no M1 machine to test with. |
I've tried v2.185.0 with Xcode 12.5 and issue is still there, I tried it with ruby 2.7.2 and even with 3.0.0. |
same issue as me :( so sad because I wanna tried fastlane with M1. |
There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Friendly reminder: contributions are always welcome! Check out CONTRIBUTING.md for more information on how to help with This issue will be auto-closed if there is no reply within 1 month. |
Still reproducible in fastlane 2.191.0. |
There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Friendly reminder: contributions are always welcome! Check out CONTRIBUTING.md for more information on how to help with This issue will be auto-closed if there is no reply within 1 month. |
…e#18502 * [Fastlane.Swift] Update to swift 5
…e#18502 * [Fastlane.Swift] Xcode recommedation. Enabling Base Internationalization is recommended for all projects. * Migrating the “English, deprecated” localization to “English” is recommended for all projects. This will ensure localized resources are placed in “en.lproj” directories instead of deprecated “English.lproj” directories.
…e#18502 * [Fastlane.Swift] Xcode recommendation. Enable recommended warnings. Implicit retain of self within blocks Overriding deprecated Objective-C methods Quoted Include in framework header.
…e#18502 * [Fastlane.Swift] Xcode recommendation. Enable code signing. It's recommended for macOS executables. This setting will cause executable's code signature to be trusted by your Mac. Currently, macOS on M1 is killing the binary at launch. According to console traces, reason is ASP Security policy would not allow process.
…e#18502 * [Fastlane.Swift] Fix waring Using 'class' keyword to define a class-constrained protocol is deprecated; use 'AnyObject' instead.
…e#18502 * [Fastlane.Swift] Fix waring 'withUnsafeBytes' is deprecated: use `withUnsafeBytes<R>(_: (UnsafeRawBufferPointer) throws -> R) rethrows -> R` instead
This is a problem related to M1 and code signing. A proper fix is to set CODE_SIGN_IDENTITY in FastlaneRunner xcodeproj With that, no more kills, nevertheless, that seems not enough.
but, trying executing anything that communicates with ruby, like a simple sh... crashes again.
My guess is that the new M1 architecture is messing with some internal raw pointers, but it's only a guess at this moment.
I'm new to ruby, so I may need some days until I can properly test more changes. |
…e#18502 * [Fastlane.Swift] Update protocol generator to use AnyObject
…e#18502 * [Fastlane.Swift] Update swift package to swift 5
…e#18502 * [Fastlane.Swift] Fix thread data race using a thread safe storage
…e#18502 * [Testing] Add some useful help to debug problems on FastlaneSwiftRunner
Copy Files seems to be working. |
…e#18502 * [Testing] Fix ensure_actions_config_items_formatting
…e#18502 * [Swift] Fix style
Just curious as to what the timeline might be for these changes to be available in public release? |
…e#18502 * [Swift] Replace DispatchQueue with os_unfair_lock as suggested in review.
…e#18502 * [Swift] Stick to swift 4, as suggested by reviewers.
…e#18502 * [Swift] Keep naming to AtomicDictionary as suggested by reviewers.
…e#18502 * [Swift] Fix CI detected error
…e#18502 * [Swift] Implement subscript as suggested by reviewers.
…e#18502 * [Swift] Restore values previous to this PR
…e#18502 * [Swift] Integrate the required steps to only upgrade the Xcode project build phase and flags needed.
…e#18502 * [Swift] Fix CI. Package deployment set to macOS 10.12
…e#18502 * [Swift] Fix CI warnings.
Hey, is there any updates on when will be able to use Fastlane swift on M1 macs |
It's under review in #19555, I hope it can be approved soon. |
Thanks for the update @kikeenrique |
Hi @kikeenrique, I think there are a few styling comments remaining to be fixed in the PR. |
…e#18502 * [Swift] Add again support for swift-tools-version 4.0 implementing a OSSpinLockAtomicDictionary for macos versions under 10.12
…e#18502 * [Swift] Add Atomic.swift to upgrade_manifest.json
…e#18502 * [Swift] Add test with fixture to check fastlane swift upgrades.
…19555) * [Fastlane.Swift] Swift fastlane does not run on Apple Silicon #18502 * [Fastlane.Swift] Update to swift 5 * [Fastlane.Swift] Swift fastlane does not run on Apple Silicon #18502 * [Fastlane.Swift] Xcode recommedation. Enabling Base Internationalization is recommended for all projects. * Migrating the “English, deprecated” localization to “English” is recommended for all projects. This will ensure localized resources are placed in “en.lproj” directories instead of deprecated “English.lproj” directories. * [Fastlane.Swift] Swift fastlane does not run on Apple Silicon #18502 * [Fastlane.Swift] Xcode recommendation. Enable recommended warnings. Implicit retain of self within blocks Overriding deprecated Objective-C methods Quoted Include in framework header. * [Fastlane.Swift] Swift fastlane does not run on Apple Silicon #18502 * [Fastlane.Swift] Xcode recommendation. Enable code signing. It's recommended for macOS executables. This setting will cause executable's code signature to be trusted by your Mac. Currently, macOS on M1 is killing the binary at launch. According to console traces, reason is ASP Security policy would not allow process. * [Fastlane.Swift] Swift fastlane does not run on Apple Silicon #18502 * [Fastlane.Swift] Fix waring Using 'class' keyword to define a class-constrained protocol is deprecated; use 'AnyObject' instead. * [Fastlane.Swift] Swift fastlane does not run on Apple Silicon #18502 * [Fastlane.Swift] Fix waring 'withUnsafeBytes' is deprecated: use `withUnsafeBytes<R>(_: (UnsafeRawBufferPointer) throws -> R) rethrows -> R` instead * [Fastlane.Swift] Swift fastlane does not run on Apple Silicon #18502 * [Fastlane.Swift] Fix waring Switch covers known cases, but 'DispatchTimeInterval' may have additional unknown values, possibly added in future versions. Handle unknown values using "@unknown default" * [Fastlane.Swift] Swift fastlane does not run on Apple Silicon #18502 * [Fastlane.Swift] Update protocol generator to use AnyObject * [Fastlane.Swift] Swift fastlane does not run on Apple Silicon #18502 * [Fastlane.Swift] Update swift package to swift 5 * [Fastlane.Swift] Swift fastlane does not run on Apple Silicon #18502 * [Fastlane.Swift] Fix thread data race using a thread safe storage * [Fastlane.Swift] Swift fastlane does not run on Apple Silicon #18502 * [Fastlane.Swift] On verbose mode, allow output from the runner thread. It allows traces and ease feedback from fastlane swift. * [Fastlane.Swift] Swift fastlane does not run on Apple Silicon #18502 * [Fastlane.Swift] Replace Build Phase - ShellScript with Build Phase - CopyFiles. This allows to copy the executable signed. * [Fastlane.Swift] Swift fastlane does not run on Apple Silicon #18502 * [Testing] Add some useful help to debug problems on FastlaneSwiftRunner * [Fastlane.Swift] Swift fastlane does not run on Apple Silicon #18502 * [Testing] Fix ensure_actions_config_items_formatting * [Fastlane.Swift] Swift fastlane does not run on Apple Silicon #18502 * [Swift] Fix style * Update fastlane/lib/fastlane/swift_lane_manager.rb Include review comments Co-authored-by: Roger Oba <rogerluan.oba@gmail.com> * Update fastlane/lib/fastlane/swift_lane_manager.rb Include review comments Co-authored-by: Roger Oba <rogerluan.oba@gmail.com> * Update Testing.md Include review comments Co-authored-by: Roger Oba <rogerluan.oba@gmail.com> * Include review comments * [Fastlane.Swift] Swift fastlane does not run on Apple Silicon #18502 * [Swift] Replace DispatchQueue with os_unfair_lock as suggested in review. * [Fastlane.Swift] Swift fastlane does not run on Apple Silicon #18502 * [Swift] Stick to swift 4, as suggested by reviewers. * [Fastlane.Swift] Swift fastlane does not run on Apple Silicon #18502 * [Swift] Keep naming to AtomicDictionary as suggested by reviewers. * [Fastlane.Swift] Swift fastlane does not run on Apple Silicon #18502 * [Swift] Fix CI detected error * [Fastlane.Swift] Swift fastlane does not run on Apple Silicon #18502 * [Swift] Implement subscript as suggested by reviewers. * [Fastlane.Swift] Swift fastlane does not run on Apple Silicon #18502 * [Swift] Restore values previous to this PR * [Fastlane.Swift] Swift fastlane does not run on Apple Silicon #18502 * [Swift] Integrate the required steps to only upgrade the Xcode project build phase and flags needed. * [Fastlane.Swift] Swift fastlane does not run on Apple Silicon #18502 * [Swift] Fix CI. Package deployment set to macOS 10.12 * [Fastlane.Swift] Swift fastlane does not run on Apple Silicon #18502 * [Swift] Fix CI warnings. * [Fastlane.Swift] Swift fastlane does not run on Apple Silicon #18502 * [Swift] Add again support for swift-tools-version 4.0 implementing a OSSpinLockAtomicDictionary for macos versions under 10.12 * Add Atomic Dictionary generic capabilities * [Fastlane.Swift] Swift fastlane does not run on Apple Silicon #18502 * [Swift] Add Atomic.swift to upgrade_manifest.json * [Fastlane.swift] Overriding doesn't call specialized extensions, fallback to #available * Cleanup hacky code Co-authored-by: Roger Oba <rogerluan.oba@gmail.com> Co-authored-by: Jorge Revuelta Herrero <minuscorp@gmail.com> Co-authored-by: Josh Holtz <me@joshholtz.com>
The pull request #19555 that closed this issue was merged and released as part of fastlane 2.204.0 🚀 |
I'll close this, let us know if any issues with M1 raises again. |
New Issue Checklist
Issue Description
When I try to run fastlane in Swift on Apple Silicone machine natively it fails on running. When I run the same command through Rosetta 2 (
arch -x86_64
) or on Intel machine, it works fine.I've tried it running it on macOS system Ruby (
ruby 2.6.3p62 (2019-04-16 revision 67580) [universal.arm64e-darwin20]
) and on latest Ruby 2.7 (ruby 2.7.2p137 (2020-10-01 revision 5445e04352) [arm64-darwin20]
) but with no luck.Command executed
bundle exec fastlane custom
Complete output when running fastlane, including the stack trace and command used
Environment
✅ fastlane environment ✅
Stack
System Locale
fastlane files:
`./fastlane/Fastfile.swift`
No Appfile found
fastlane gems
Loaded fastlane plugins:
No plugins Loaded
Loaded gems
generated on: 2021-04-02
The text was updated successfully, but these errors were encountered: