Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fastlane.Swift] Swift fastlane does not run on Apple Silicon #19755

Conversation

kikeenrique
Copy link
Contributor

  • [Swift] Add test with fixture to check fastlane swift upgrades.

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Adds swift fastlane tests that:

Description

  • Add a fastlane swift project fixture, based on fastlane v2.198. The project also implements a simple "custom" lane.
  • Add a extra step to generate_swift_api
  • Add --enable_runner_upgrades parameter to allow auto accept changes on fastlaneRunner upgrades.

Testing Steps

Executing bundle exec fastlane generate_swift_api

…e#18502

* [Swift] Add test with fixture to check fastlane swift upgrades.
@minuscorp
Copy link
Collaborator

minuscorp commented Dec 30, 2021

We shouldn't add the code duplicated as a fixture, this is unmaintainable in the long run, this should be closed and use the other PR better.
Add the improvements to the other PR, like the flag and so on.

@kikeenrique
Copy link
Contributor Author

How would you test then swift project upgrades?
My intention would not be to upgrade fixtures, they will be use to test project upgrades from each version.
Every modification in fastlane runner xcode project should be updated in fastlane runner project, and you can't foresee when a user will update versions.

@minuscorp
Copy link
Collaborator

Maintenance of Swift is made when there're requirements for it, it makes no sense to use a fixture because it wouldn't be the real code when somebody makes a change if you are using a static version of all the runner and the project itself. The flag and the other changes are good to add in the other PR.

@fastlane fastlane locked and limited conversation to collaborators Mar 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants