Uploading assets with a GitHub release fails in set_github_release

[provTheodoreNewell]

New Issue Checklist

• [x ] Updated fastlane to the latest version
• [x ] I have read the Contribution Guidelines

Issue Description

Using the set_github_release action in Fastlane 2.50.0 with a valid array of paths for the upload_assets and relying on the default value for git_url (https://api.github.com) fails during the upload step, printing the error:

Please provide server URL, eg: https://api.github.com

This seems to be a regression introduced with the new github_api action at #8971.

Proposed Solution

In github_api.rb::construct_url, valid combinations of parameters should be either:

1. server_url in conjunction with path that can be joined to create a full url
   or
2. url as the full url

I will prepare a pull request with this solution.

Fastlane Version

fastlane gems

Gem	Version	Update-Status
fastlane	2.50.0	✅ Up-To-Date

[ohayon]

Thanks for raising the issue @provTheodoreNewell ! We would be happy to review that PR ! 🚀

[JohnEstropia]

We're still experiencing a problem with the new Github actions (Fastlane 2.50.1) and it seems to be related to content-types:

[16:56:03]: Creating release of <redacted> on tag "<redacted>" with name "<redacted>".
[16:56:03]: Will also upload assets ["<redacted>.ipa", "<redacted>.app.dSYM.zip"].
[16:56:04]: Successfully created release at tag "<redacted>" on GitHub
[16:56:04]: See release at "https://github.com/<redacted>/releases/tag/<redacted>"
[16:56:05]: Uploading <redacted>.ipa
[16:56:32]: GitHub responded with 400:{"message":"Invalid Content-Type: ''","request_id":"CC20:3C83:6E76CA:755512:59842897"}
+-------------------------------+-------------------------------------------------------------------------------------------------------------------------------+
|                                                                         Lane Context                                                                          |
+-------------------------------+-------------------------------------------------------------------------------------------------------------------------------+
| DEFAULT_PLATFORM              | ios                                                                                                                           |
| PLATFORM_NAME                 | ios                                                                                                                           |
| LANE_NAME                     | ios deploy                                                                                                                    |
| GIT_REPO_WAS_CLEAN_ON_START   | true                                                                                                                          |
| SIGH_PROFILE_PATH             | /Users/<redacted>.mobileprovision                                  |
| SIGH_PROFILE_PATHS            | ["/Users/<redacted>.mobileprovision"]                              |
| SIGH_UDID                     | 8298b6c0-643d-4052-816b-4f59c7787f4f                                                                                          |
| SIGH_UUID                     | 8298b6c0-643d-4052-816b-4f59c7787f4f                                                                                          |
| SIGH_PROFILE_TYPE             | app-store                                                                                                                     |
| IPA_OUTPUT_PATH               | /Users/<redacted>.ipa                                              |
| DSYM_OUTPUT_PATH              | /Users/<redacted>.app.dSYM.zip                                     |
| XCODEBUILD_ARCHIVE            | /Users/<redacted>.xcarchive          |
| VERSION_NUMBER                | <redacted>                                                                                                                        |
| BUILD_NUMBER                  | <redacted>                                                                                                                           |
| SET_GITHUB_RELEASE_HTML_LINK  | https://github.com/<redacted>/releases/tag/<redacted>                                              |
| SET_GITHUB_RELEASE_RELEASE_ID | 7281426                                                                                                                       |
| SET_GITHUB_RELEASE_JSON       | {"url"=>"https://api.github.com/repos/<redacted>/releases/7281426",                                                       |
|                               | "assets_url"=>"https://api.github.com/repos/<redacted>/releases/7281426/assets",                                          |
|                               | "upload_url"=>"https://uploads.github.com/repos/<redacted>/releases/7281426/assets{?name,label}",                         |
|                               | "html_url"=>"https://github.com/<redacted>/releases/tag/<redacted>", "id"=>7281426,                |
|                               | "tag_name"=>"<redacted>", "target_commitish"=>"develop", "name"=>"<redacted>",  |
|                               | "draft"=>false, "author"=>{"login"=>"JohnEstropia", "id"=>3029684,                                                            |
|                               | "avatar_url"=>"https://avatars0.githubusercontent.com/u/3029684?v=4", "gravatar_id"=>"",                                      |
|                               | "url"=>"https://api.github.com/users/JohnEstropia", "html_url"=>"https://github.com/JohnEstropia",                            |
|                               | "followers_url"=>"https://api.github.com/users/JohnEstropia/followers",                                                       |
|                               | "following_url"=>"https://api.github.com/users/JohnEstropia/following{/other_user}",                                          |
|                               | "gists_url"=>"https://api.github.com/users/JohnEstropia/gists{/gist_id}",                                                     |
|                               | "starred_url"=>"https://api.github.com/users/JohnEstropia/starred{/owner}{/repo}",                                            |
|                               | "subscriptions_url"=>"https://api.github.com/users/JohnEstropia/subscriptions",                                               |
|                               | "organizations_url"=>"https://api.github.com/users/JohnEstropia/orgs",                                                        |
|                               | "repos_url"=>"https://api.github.com/users/JohnEstropia/repos",                                                               |
|                               | "events_url"=>"https://api.github.com/users/JohnEstropia/events{/privacy}",                                                   |
|                               | "received_events_url"=>"https://api.github.com/users/JohnEstropia/received_events", "type"=>"User", "site_admin"=>false},     |
|                               | "prerelease"=>true, "created_at"=>"2017-08-03T10:43:24Z", "published_at"=>"2017-08-04T07:56:04Z", "assets"=>[],               |
|                               | "tarball_url"=>"https://api.github.com/repos/<redacted>/tarball/<redacted>",                       |
|                               | "zipball_url"=>"https://api.github.com/repos/<redacted>/zipball/<redacted>",                       |
|                               | "body"=>"<redacted>\n"}                                                                                           |
+-------------------------------+-------------------------------------------------------------------------------------------------------------------------------+
[16:56:33]: Failed to upload asset <redacted>.ipa to GitHub.

+------+-----------------------------------------+-------------+
|                       fastlane summary                       |
+------+-----------------------------------------+-------------+
| Step | Action                                  | Time (in s) |
+------+-----------------------------------------+-------------+
| 1    | default_platform                        | 0           |
| 2    | update_fastlane                         | 2           |
| 3    | reset_git_repo                          | 0           |
| 4    | ensure_git_status_clean                 | 0           |
| 5    | git_branch                              | 0           |
| 6    | git fetch origin                        | 3           |
| 7    | git_pull                                | 6           |
| 8    | git submodule update --init --recursive | 0           |
| 9    | update_fastlane                         | 0           |
| 10   | xcversion                               | 2           |
| 11   | sigh                                    | 7           |
| 12   | gym                                     | 926         |
| 13   | get_version_number                      | 3           |
| 14   | get_build_number                        | 0           |
| 💥   | set_github_release                      | 28          |
+------+-----------------------------------------+-------------+

[16:56:33]: fastlane finished with errors

[!] Failed to upload asset <redacted>.ipa to GitHub.

Edit

Forgot to mention, our set_github_release usage used to work just fine.

[mathroule]

I'm experiencing the same issue using Fastlane 2.50.1

[ganjarpanji]

i got this error
GitHub responded with 400:{"message":"Invalid Content-Type: ''","request_id":"DDD5:1BAFB:D6BDB6:E7924C:59841FEC"}`

the actions doesnt provide content_type parameter

[provTheodoreNewell]

I noticed the regression too. It looks like the "application/zip" content type header should always be used in the `uploa_file` function in `set_github_release`, not just for paths that include ".zip" to meet the previous behavior. I will make a PR with the fix later this morning if no one beats me too it :) On Aug 4, 2017, at 4:18 AM, Ganjar Panji Manggala <notifications@github.com<mailto:notifications@github.com>> wrote: i got this error GitHub responded with 400:{"message":"Invalid Content-Type: ''","request_id":"DDD5:1BAFB:D6BDB6:E7924C:59841FEC"}` @JohnEstropia<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_johnestropia&d=DwMCaQ&c=KoC5GYBOIefzxGAm2j6cjFf-Gz7ANghQIP9aFG9DuBs&r=_-85IUQj7hxsyqtTXBqqx-N-2drhDGG9LpbNKN2S6Rg&m=o8VzKB5tra2TRrxQLQHcXK5BrqbjkWpGHnra5OVChGE&s=iNB0x8j0TxkvAZ8cYuH6laABAfol-PC9h_p2D6k_HMM&e=> how you fix it? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_fastlane_fastlane_issues_9922-23issuecomment-2D320224297&d=DwMCaQ&c=KoC5GYBOIefzxGAm2j6cjFf-Gz7ANghQIP9aFG9DuBs&r=_-85IUQj7hxsyqtTXBqqx-N-2drhDGG9LpbNKN2S6Rg&m=o8VzKB5tra2TRrxQLQHcXK5BrqbjkWpGHnra5OVChGE&s=tSJ5iF0H5lo8VZePNNmo2u6egw3vJfqYNIWamc7R5-c&e=>, or mute the thread<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AcNXAbNU8vsE9xQ213VLn8HJq-5F4Zzb8Cks5sUv4RgaJpZM4OqMO6&d=DwMCaQ&c=KoC5GYBOIefzxGAm2j6cjFf-Gz7ANghQIP9aFG9DuBs&r=_-85IUQj7hxsyqtTXBqqx-N-2drhDGG9LpbNKN2S6Rg&m=o8VzKB5tra2TRrxQLQHcXK5BrqbjkWpGHnra5OVChGE&s=1KxdXSKnkdOQelgZ_AhC_hUY7yrMPxNJtu_5dv75HRM&e=>.

…

________________________________ This message is intended for the sole use of the addressee, and may contain information that is privileged, confidential and exempt from disclosure under applicable law. If you are not the addressee you are hereby notified that you may not use, copy, disclose, or distribute to anyone the message or any information contained in the message. If you have received this message in error, please immediately advise the sender by reply email and delete this message.