-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for #9922, Part 2: content type #9965
Fix for #9922, Part 2: content type #9965
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AMAZING! Thanks for making these fixes @provTheodoreNewell !! 🚀
😄 |
Hey @provTheodoreNewell 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
is this not released yet? could we make the release faster? as our teams need to attach the binaries immediately 😄 |
ah nevermind, its still possible with .zip though. thanks for the fix anyway @provTheodoreNewell |
Hehe, we generally avoid shipping new releases during a weekend 😉 |
Congratulations! 🎉 This was released as part of fastlane 2.51.0 🚀 |
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validMotivation and Context
As commented on #9922, an additional regression with the introduction of the new
github_api
action at #8971 causes file uploads to fail in theset_github_release
action when the filename does not include ".zip".Description
This PR restores the pre-existing behavior of using the
application/zip
content type header for all uploaded binary files.