Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #9922, Part 2: content type #9965

Merged
merged 3 commits into from
Aug 4, 2017

Conversation

provTheodoreNewell
Copy link
Contributor

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

As commented on #9922, an additional regression with the introduction of the new github_api action at #8971 causes file uploads to fail in the set_github_release action when the filename does not include ".zip".

Description

This PR restores the pre-existing behavior of using the application/zip content type header for all uploaded binary files.

Copy link
Contributor

@ohayon ohayon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AMAZING! Thanks for making these fixes @provTheodoreNewell !! 🚀

@ohayon ohayon merged commit 94dee32 into fastlane:master Aug 4, 2017
@provTheodoreNewell
Copy link
Contributor Author

😄

@fastlane-bot
Copy link

Hey @provTheodoreNewell 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@ganjarpanji
Copy link

is this not released yet? could we make the release faster? as our teams need to attach the binaries immediately 😄

@ganjarpanji
Copy link

ah nevermind, its still possible with .zip though. thanks for the fix anyway @provTheodoreNewell

@KrauseFx
Copy link
Member

KrauseFx commented Aug 7, 2017

Hehe, we generally avoid shipping new releases during a weekend 😉

@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.51.0 🚀

dvdchr pushed a commit to dvdchr/fastlane that referenced this pull request Sep 5, 2017
@fastlane fastlane locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants