Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ErrorHandler isn't needed when building swift FastlaneRunner #11326

Merged
merged 1 commit into from
Dec 22, 2017
Merged

ErrorHandler isn't needed when building swift FastlaneRunner #11326

merged 1 commit into from
Dec 22, 2017

Conversation

taquitos
Copy link
Collaborator

KrauseFx
KrauseFx approved these changes Dec 22, 2017
View reviewed changes
Copy link
Member

@KrauseFx KrauseFx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The best commit, who needs error handling

@taquitos
Copy link
Collaborator Author

Error handling was causing too many errors

@acegreen
Copy link

You are the king 💯

@taquitos taquitos merged commit 6160210 into master Dec 22, 2017
@taquitos taquitos deleted the 11317 branch December 22, 2017 16:11
@KrauseFx
Copy link
Member

@taquitos really is the 👑

@fastlane-bot
Copy link

Hey @taquitos 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

This was referenced Dec 24, 2017
Closed
Merged
@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.71.0 🚀

RishabhTayal added a commit to RishabhTayal/fastlane that referenced this pull request Dec 27, 2017
@RishabhTayal
Merge branch 'fastlane/master' into spaceship-review-response-methods
94cd2a6 
* fastlane/master:
  Fix match? -> match (fixes fastlane#11350) (fastlane#11351)
  Fix version_number_from_tag tests (fastlane#11347)
  Version bump to 2.71.0 (fastlane#11341)
  Update Swift API generation to handle default values for Procs correctly (fastlane#11340)
  Enable rubocop cache on Circle (fastlane#11334)
  Add option to force device frame orientation (fixes fastlane#10928) (fastlane#11161)
  Flatten application_id in match (fastlane#11333)
  Add a link to GitHub Working with Forks docs. (fastlane#11328)
  ErrorHandler isn't needed when building swift FastlaneRunner (fastlane#11326)
  Circle CI: Run in Ubuntu and macOS environments, in parallel (fastlane#11242)
  Testflight: New method to create group (fastlane#11321)
  appledoc: accept multiple input paths (fastlane#11290)
  Fetch the correct prices from the new API in spaceship (fastlane#11314)
  Android Appfile template: updated link to `supply` setup instructions (fastlane#11313)
  Make swift code generation more aware of sensitive default values (fastlane#11301)
  Version bump first, then generate swift (fastlane#11318)
  Add return type to get_version_number so it's accessible in Swift (fastlane#11315)
  [CircleCI] Fix failing "Uploading test results" (fastlane#11304)
@LiuLian1992 LiuLian1992 mentioned this pull request Dec 29, 2017
Closed
@fastlane fastlane locked and limited conversation to collaborators Feb 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@KrauseFx KrauseFx KrauseFx approved these changes

Assignees
No one assigned
Labels
cla: yes status: released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error running fastlane swift
5 participants
@taquitos @acegreen @KrauseFx @fastlane-bot @googlebot