-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update fastlane UI handler to support FastlaneCI rendering #11857
Conversation
Whops tests fail |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎈:goat:
Will fix the tests later on, as soon as the implementation fully works |
I couldn't help but notice..... |
expect(FastlaneCore::UI.current).to receive(:select).and_return("Local Path") | ||
expect(FastlaneCore::UI.current).to receive(:input).and_return("../yoo") | ||
expect(FastlaneCore::UI.ui_object).to receive(:select).and_return("Local Path") | ||
expect(FastlaneCore::UI.ui_object).to receive(:input).and_return("../yoo") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OMG I LOVE TESTS
@@ -0,0 +1,22 @@ | |||
require 'spec_helper' | |||
|
|||
describe FastlaneCore::UI do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
🎈🐐🎈🐐🎈🐐 |
Whoops, apparently buttons confuse me. |
Hey @KrauseFx 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
Congratulations! 🎉 This was released as part of fastlane 2.84.0 🚀 |
Related to fastlane/ci#139