Make CredentialsManager output more Windows friendly #13154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janpio
changed the title
This comment has been minimized.
This comment has been minimized.
janpio
changed the title
|
Hey @janpio 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
|
Congratulations! 🎉 This was released as part of fastlane 2.103.0 🚀 |
janpio
added a commit
to janpio/fastlane
that referenced
this pull request
Sep 11, 2018
* make CredentialsManager output more windows friendly * replace Helper.mac? with local copy * -self * only less output
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validMotivation and Context
CredentialsManagercurrently talks about Keychain. This of course doesn't mean anything to Windows users as Keychain doesn't exist.Description
This PR disables some output by checking if fastlane is running on Windows.