-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[resign.sh] Add healthkit access entitlement to the blacklist and transfer list #13798
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
CLAs look good, thanks! |
|
Yes, when you use the The blacklist will prevent the script from copying over the entitlement from the provisioning profile Which would by default contain the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! 👍
Hey @Travolter 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
Congratulations! 🎉 This was released as part of fastlane 2.115.0 🚀 |
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validMotivation and Context
com.apple.developer.healthkit
is an entitlement that should also be taken from the App.Before resigning:
After running
resign.sh HealthKit_sample.ipa XXXXX -p "Healthkitswift_test_distribution.mobileprovision" --use-app-entitlements fastlane_resigned.healthkit.ipa
:This is obviously not correct, with this patch it's back to the original entitlements.
Description
Added the
"com.apple.developer.healthkit.access"
entitlements to the list of entitlements that should not be taken from the provisioning profile but from the app.