Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[action] add symbols and booleans in modify_services action #14215

Merged
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 9 additions & 6 deletions fastlane/lib/fastlane/actions/modify_services.rb
Expand Up @@ -12,8 +12,8 @@ def self.run(params)
require 'produce/service'
services = params[:services]

enabled_services = services.reject { |k, v| v == 'off' }
disabled_services = services.select { |k, v| v == 'off' }
enabled_services = services.select { |_k, v| v == :on || v == 'on' || v == true }.map { |k, v| [k, 'on'] }.to_h
MartinGonzalez marked this conversation as resolved.
Show resolved Hide resolved
disabled_services = services.reject { |_k, v| v == :on || v == 'on' || v == true }.map { |k, v| [k, 'off'] }.to_h
MartinGonzalez marked this conversation as resolved.
Show resolved Hide resolved

enabled_services_object = self.service_object
enabled_services.each do |k, v|
Expand Down Expand Up @@ -72,7 +72,7 @@ def self.services_mapping

def self.allowed_services_description
return Produce::DeveloperCenter::ALLOWED_SERVICES.map do |k, v|
"#{k}: (#{v.join('|')})"
"#{k}: (#{v.join('|')})(:on|:off)(true|false)"
end.join(", ")
end

Expand Down Expand Up @@ -158,9 +158,12 @@ def self.example_code
app_identifier: "com.someorg.app",
services: {
push_notification: "on",
associated_domains: "off"
}
)'
associated_domains: "off",
wallet: :on,
apple_pay: :off,
data_protection: true,
multipath: false
joshdholtz marked this conversation as resolved.
Show resolved Hide resolved
})'
]
end

Expand Down