[spaceship] Automate phone number selection for "request code via SMS" in 2FA with SPACESHIP_2FA_SMS_DEFAULT_PHONE_NUMBER env var

[janpio]

Checklist

• I've run bundle exec rspec from the root directory to see all new and existing tests pass
• I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
• I've read the Contribution Guidelines
• I've updated the documentation if necessary.

Motivation and Context

2FA with token entry is a hassle to fastlane users. Some use cases also force people to use trusted phone numbers instead of the usual pushed tokens, so we can streamline their workflow by allowing them to skip the pushed token and remove the necessary interaction to get a token sent to a specific phone number.

Description

The new environment variable SPACESHIP_2FA_SMS_DEFAULT_PHONE_NUMBER allows you to set a phone number, that is automatically used as the recipient of the 2FA token. You do not have to "escape" the normal input via inputting sms and then selecting your phone number from a dropdown any more.

Testing

I wrote a few tests for the specific methods I introduced that helped me to make sure they actually do what I expected them to do. Then I manually tested via bundle exec fastlane spaceauth as it basically just does the spaceship login - which is what this code impacts.

Unrelated changes

This PR also includes a little comment in the cert runner and changes the way fastlane spaceauth handles exceptions - before they were just swallowed, but as my new code raises one if it can't find the correct phone number, that was not very good for testing. Now they are bubbled up to the user.

closes #13980

---

Review Notes

• I am not really happy with the code of phone_id_from_number, the way I find the phone_id for the value of the ENV variable via the regex pattern, and especially the way I build it looks really crap and complicated. Is there a better way to do this?
• Does my spec file make sense? It worked for me when writing the initial code, but are those actually good tests? Should I do more here? The whole file was completely untested before. Now at least those two methods I touched are tested a tiny bit.

[max-ott]

Thanks for your great work @janpio 🙏 Will test this and give feedback. Is only running bundle exec fastlane spaceauth required to test this with having the right ENV set?

[janpio]

That should execute that code, yes. But testing in other circumstances (normal spaceship usage) is of course also welcome.

[joshdholtz]

@janpio I left a few small suggestions about masking numbers and changing some of the CLI output but this is so 🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥

[janpio]

Documentation part of this PR is taken care of via #14524 which will create https://github.com/fastlane/fastlane/blob/master/spaceship/docs/Authentication.md

[joshdholtz]

This is so goooooood! We are shipping this tomorrow 💪

[fastlane-bot]

Hey @janpio 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

[fastlane-bot]

Congratulations! 🎉 This was released as part of fastlane 2.121.0 🚀