Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[spaceship] Automate phone number selection for "request code via SMS" in 2FA with SPACESHIP_2FA_SMS_DEFAULT_PHONE_NUMBER env var #14436

Merged
merged 20 commits into from Apr 19, 2019
Merged

[spaceship] Automate phone number selection for "request code via SMS" in 2FA with SPACESHIP_2FA_SMS_DEFAULT_PHONE_NUMBER env var #14436

merged 20 commits into from Apr 19, 2019

Commits on Apr 18, 2019

  1. implement SPACESHIP_2FA_SMS_DEFAULT_PHONE_NUMBER

    @janpio
    janpio committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    99d1e19 View commit details
    Browse the repository at this point in the history

  2. tests for phone_id_from_number

    @janpio
    janpio committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    23d9eb6 View commit details
    Browse the repository at this point in the history

  3. unrelated comment change

    @janpio
    janpio committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    da22618 View commit details
    Browse the repository at this point in the history

  4. make rubocop happy

    @janpio
    janpio committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    30f5522 View commit details
    Browse the repository at this point in the history

  5. fix code for older ruby versions

    @janpio
    janpio committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    cc79030 View commit details
    Browse the repository at this point in the history

  6. also work for country code with 3 digits

    @janpio
    janpio committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    1edac3c View commit details
    Browse the repository at this point in the history

  7. helpful output that surfaces SPACESHIP_2FA_SMS_DEFAULT_PHONE_NUMBER

    @janpio
    janpio committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    746423c View commit details
    Browse the repository at this point in the history

  8. set missing code type value when ENV var is present

    @janpio
    janpio committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    43ca0ed View commit details
    Browse the repository at this point in the history

  9. also remove " from ENV var (which tends to be added by silly windows … 

    …developer [like me!])
    @janpio
    janpio committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    6221186 View commit details
    Browse the repository at this point in the history

  10. [spaceauth] surface more information about exceptions

    @janpio
    janpio committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    5f69f8a View commit details
    Browse the repository at this point in the history

  11. terrible first try at testing handle_two_factor

    @janpio
    janpio committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    28889a9 View commit details
    Browse the repository at this point in the history

  12. fix wrong env var (wtf how did this work before?)

    @janpio
    janpio committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    7fba019 View commit details
    Browse the repository at this point in the history

  13. clean up tests

    @janpio
    janpio committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    1e6768a View commit details
    Browse the repository at this point in the history

  14. maybe?

    @janpio
    janpio committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    22acae2 View commit details
    Browse the repository at this point in the history

  15. make rubocop happy

    @janpio
    janpio committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    8d5b2f0 View commit details
    Browse the repository at this point in the history

  16. future tests

    @janpio
    janpio committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    7dd9de3 View commit details
    Browse the repository at this point in the history

  17. rubocop

    @janpio
    janpio committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    970c7fc View commit details
    Browse the repository at this point in the history

  18. check if ENV var SPACESHIP_2FA_SMS_DEFAULT_PHONE_NUMBER is empty 

    only read ENV var once
    @janpio
    janpio committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    4b99afb View commit details
    Browse the repository at this point in the history

  19. rename variable

    @janpio
    janpio committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    00da023 View commit details
    Browse the repository at this point in the history

  20. add link to future docs page 

    and some empty lines for structure
    @janpio
    janpio committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    544f923 View commit details
    Browse the repository at this point in the history