[action] app_store_build_number: Pass teamID when selecting itunes team

[lexorus]

Checklist

• I've run bundle exec rspec from the root directory to see all new and existing tests pass
• I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
• I've read the Contribution Guidelines
• I've updated the documentation if necessary.

Motivation and Context

We are using the LatestTestflightBuildNumberAction for incrementing our project build number. We are providing all the necessary params and credentials for signing and it was working smooth. Lately, I guess after unification of AppStoreConnect and DeveloperPortal teams, fastlane is asking to specify the team id even if we are passing it within the params.

Multiple App Store Connect teams found, please enter the number of the team you want to use:
Note: to automatically choose the team, provide either the App Store Connect Team ID, or the Team Name in your fastlane/Appfile:
Alternatively you can pass the team name or team ID using the `FASTLANE_ITC_TEAM_ID` or `FASTLANE_ITC_TEAM_NAME` environment variable
{...}

If we pass the environment variable before launching this fastlane action, everything works. But we are passing it through the parameters, and it should also work. I started looking where the problem is and found that when AppStoreBuildNumberAction is preparing Spaceship::Tunes, it was not passing the specified team_id.

Spaceship::Tunes.login(params[:username])
Spaceship::Tunes.select_team #no team_id passed

Adding the team_id parameter solved the issue.

Description

There is a pretty small change and it is described above in detail. About how did I test it, I tested within our own project, the next use cases:

1. faslane is automatically Login to App Store Connect when a FASTLANE_ITC_TEAM_ID env var is set
2. faslane is automatically Login to App Store Connect when team_id argument is passed to the
   LatestTestflightBuildNumberAction
3. If neither of above is done, fastlane is asking for the teamID within the dialog.

[janpio]

Context for someone reviewing this: latest_testflight_build_numberaction internally usesapp_store_build_number` action.

[joshdholtz]

While we are in here... we should remove the setting of the ENVs from the verify_block like we did here with that are in the team_id and team_name options since that is not what it is meant for 🙃

[joshdholtz]

Can we also add team_name in here as well?

Suggested change

	Spaceship::Tunes.select_team(team_id: params[:team_id])
	Spaceship::Tunes.select_team(team_id: params[:team_id], team_name: params[:team_name])

[lexorus]

Updated with both requested changes.

[joshdholtz]

Thanks for making those changes! This is 🔥

[fastlane-bot]

Hey @lexorus 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

[fastlane-bot]

Congratulations! 🎉 This was released as part of fastlane 2.121.0 🚀